[Bugs] [Bug 1320412] New: disperse: Provide an option to enable/disable eager lock

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1320412

            Bug ID: 1320412
           Summary: disperse: Provide an option to enable/disable eager
                    lock
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: glusterfs
     Sub Component: disperse
          Assignee: rhs-bugs at redhat.com
          Reporter: aspandey at redhat.com
        QA Contact: byarlaga at redhat.com
                CC: bugs at gluster.org
        Depends On: 1314649
            Blocks: 1318965



+++ This bug was initially created as a clone of Bug #1314649 +++

Description of problem:

If a fop takes lock, and completes its operation, it waits for 1 second before 
releasing the lock. However, If ec find any lock contention within this time
period, it release the lock immediately before time expires.

As we take lock on first brick, In some operation, like read, it might happen
that discovery of lock contention might take long time and can degrades the
performance.


Provide an option to enable/disable eager lock 



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-03-04 03:06:06 EST ---

REVIEW: http://review.gluster.org/13605 (cluster/ec: Provide an option to
enable/disable eager lock) posted (#1) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-11 02:44:55 EST ---

REVIEW: http://review.gluster.org/13605 (cluster/ec: Provide an option to
enable/disable eager lock) posted (#2) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-14 03:13:38 EDT ---

REVIEW: http://review.gluster.org/13605 (cluster/ec: Provide an option to
enable/disable eager lock) posted (#3) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-15 01:41:30 EDT ---

REVIEW: http://review.gluster.org/13605 (cluster/ec: Provide an option to
enable/disable eager lock) posted (#4) for review on master by Ashish Pandey
(aspandey at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-16 00:54:35 EDT ---

COMMIT: http://review.gluster.org/13605 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 23ccabbeb7879fd05f415690124bd7b4a74d4d33
Author: Ashish Pandey <aspandey at redhat.com>
Date:   Fri Mar 4 13:05:09 2016 +0530

    cluster/ec: Provide an option to enable/disable eager lock

    Problem: If a fop takes lock, and completes its operation,
    it waits for 1 second before releasing the lock. However,
    If ec find any lock contention within this time period,
    it release the lock immediately before time expires. As we
    take lock on first brick, for few operations, like read, it
    might happen that discovery of lock contention might take
    long time and can degrades the performance.

    Solution: Provide an option to enable/disable eager lock.
    If eager lock is disabled, lock will be released as soon
    as fop completes.

    gluster v set <VOLUME NAME> disperse.eager-lock on
    gluster v set <VOLUME NAME> disperse.eager-lock off

    Change-Id: I000985a787eba3c190fdcd5981dfbf04e64af166
    BUG: 1314649
    Signed-off-by: Ashish Pandey <aspandey at redhat.com>
    Reviewed-on: http://review.gluster.org/13605
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1314649
[Bug 1314649] disperse: Provide an option to enable/disable eager lock
https://bugzilla.redhat.com/show_bug.cgi?id=1318965
[Bug 1318965] disperse: Provide an option to enable/disable eager lock
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nkOCqJUPJO&a=cc_unsubscribe