[Bugs] [Bug 1319645] New: setting enable-shared-storage without mentioning the domain, doesn't enables shared storage

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1319645

            Bug ID: 1319645
           Summary: setting enable-shared-storage without mentioning the
                    domain, doesn't enables shared storage
           Product: GlusterFS
           Version: 3.7.0
         Component: build
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: ggarg at redhat.com
                CC: ashah at redhat.com, bugs at gluster.org, ggarg at redhat.com,
                    nlevinki at redhat.com, rjoseph at redhat.com,
                    sasundar at redhat.com, smohan at redhat.com,
                    vbellur at redhat.com
        Depends On: 1238224, 1236153



+++ This bug was initially created as a clone of Bug #1238224 +++

+++ This bug was initially created as a clone of Bug #1236153 +++

Description of problem:
-----------------------
Setting the option, enable-shared-storage, without mentioning the domain
'cluster' doesn't creates the gluster_shared_storage volume

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
glusterfs-3.7.1-5.el6rhs

How reproducible:
------------------
Always

Steps to Reproduce:
--------------------
1. Create a volume of any type
2. Enable enable-shared-storage on the volume, without mentioning the domain
(i.e) gluster volume set all enable-shared-storage enable

Actual results:
---------------
Setting enabling the option enable-shared-storage doesn't created the shared
gluster volume by name gluster_shared_storage

Expected results:
-----------------
gluster_shared_storage should be created when enable-shared-storage is enabled

Additional info:
----------------
RCA is here.
The hook script
'/var/lib/glusterd/hooks/1/set/post/S32gluster_enable_shared_storage.sh' checks
for the key 'cluster.enable-shared-storage' and exits when the key is
'enable-shared-storage'

<snip_from_hook_script>
if [ "$key" != "cluster.enable-shared-storage" ]; then
    exit;
fi
</snip_from_hook_script>

--- Additional comment from Anand Avati on 2015-07-01 08:31:07 EDT ---

REVIEW: http://review.gluster.org/11491 (extra: "enable-shared-storage" key
should create shared-storage) posted (#1) for review on master by Gaurav Kumar
Garg (ggarg at redhat.com)

--- Additional comment from Anand Avati on 2015-07-13 06:26:02 EDT ---

COMMIT: http://review.gluster.org/11491 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 890e58f5d4d3db9477e36cac3d16798ffe3b0480
Author: Gaurav Kumar Garg <ggarg at redhat.com>
Date:   Wed Jul 1 17:55:47 2015 +0530

    extra: "enable-shared-storage" key should create shared-storage

    Currently while creating shared storage it accept only
    "cluster.enable-shared-storage" key. It should also
    accept "enable-shared-storage" key.

    Change-Id: I4c68782f4b7927ec8cd725e411b0b9db17d9c48d
    BUG: 1238224
    Signed-off-by: Gaurav Kumar Garg <ggarg at redhat.com>
    Reviewed-on: http://review.gluster.org/11491
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Reviewed-by: Avra Sengupta <asengupt at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1236153
[Bug 1236153] setting enable-shared-storage without mentioning the domain,
doesn't enables shared storage
https://bugzilla.redhat.com/show_bug.cgi?id=1238224
[Bug 1238224] setting enable-shared-storage without mentioning the domain,
doesn't enables shared storage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.