[Bugs] [Bug 1312845] Protocol server/client handshake gap

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 10 17:24:39 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1312845



--- Comment #4 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13549 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 2bfdc30e0e7fba6f97d8829b2618a1c5907dc404
Author: Avra Sengupta <asengupt at redhat.com>
Date:   Mon Feb 29 14:43:58 2016 +0530

    protocol client/server: Fix client-server handshake

    Problem:
    Currently on a successful connection between protocol
    server and client, the protocol client initiates a
    CHILD_UP event in the client stack. At this point in
    time, only the connection between server and client is
    established, and there is no guarantee that the server
    side stack is ready to serve requests.

    It works fine now, as most server side translators are
    not dependent on any other factors, before being able
    to serve requests today and hence they are up by the time
    the client stack translators receive the CHILD_UP (initiated
    by client handshake).

    The gap here is exposed when certain server side translators
    like NSR-Server for example, have a couple of protocol clients
    as their child(connecting them to other bricks), and they
    can't really serve requests till a quorum of their children are
    up. Hence these translators should defer sending CHILD_UP
    till they have enough children up, and the same needs to be
    propagated to the client stack translators.

    Fix:
    Maintain a child_up variable in both the protocol client
    and protocol server translators. The protocol server should
    update this value based on the CHILD_UP and CHILD_DOWN
    events it receives from the translators below it. On receiving
    such an event it should forward that event to the client.
    The protocol client on receiving such an event should forward
    it up the client stack, thereby letting the client translators
    correctly know that the server is up and ready to serve.

    The clients connecting later(long after a server has initialized
    and processed it's CHILD_UP events), will receive a child_up status
    as part of the handshake, and based on the status of the server's
    child_up, can either propagate a CHILD_UP event or defer it.

    Change-Id: I0807141e62118d8de9d9cde57a53a607be44a0e0
    BUG: 1312845
    Signed-off-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-on: http://review.gluster.org/13549
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R7195dvcqK&a=cc_unsubscribe


More information about the Bugs mailing list