[Bugs] [Bug 1316436] New: IFS is not set back after used as "[" in log_newer function of include.rc

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 10 09:02:05 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1316436

            Bug ID: 1316436
           Summary: IFS is not set back after used as "[" in log_newer
                    function of include.rc
           Product: GlusterFS
           Version: 3.7.9
         Component: tests
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: rtalur at redhat.com
                CC: bugs at gluster.org, fanghuang.data at yahoo.com,
                    pkarampu at redhat.com
        Depends On: 1245425



+++ This bug was initially created as a clone of Bug #1245425 +++

Description of problem:

In log_newer function, IFS is set to "[". It should be set back before the
function return. This causes the last cleanup in basic/afr/self-heald.t to
create a diretory "/d/backends\ /mnt/glusterfs/0\ /mnt/glusterfs/1\
/mnt/glusterfs/2\ /mnt/nfs/0\ /mnt/nfs/1/".

The following is part of the log file. The bash shell add single quotes to the
variable WORKDIRS

+ umount -l /mnt/nfs/1
+ umount -f /mnt/nfs/1
+ true
+ rm -rf '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2
/mnt/nfs/0 /mnt/nfs/1'
+ leftover=
+ for d in '$WORKDIRS'
+ test -d '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2
/mnt/nfs/0 /mnt/nfs/1'
+ '[' x '!=' x ']'
+ mkdir -p '/d/backends /mnt/glusterfs/0 /mnt/glusterfs/1 /mnt/glusterfs/2
/mnt/nfs/0 /mnt/nfs/1'
+ return 0
+ exit


Version-Release number of selected component (if applicable):

3.7.2

How reproducible:

always

Steps to Reproduce:
1. ./run-tests ./test/basic/afr/self-heald.t
2. ls /d
backends  backends 

Actual results:

Two directories "backends  backends " are shown.

Expected results:

only one "backends" directory exits.

Additional info:

--- Additional comment from Anand Avati on 2015-07-28 19:24:51 IST ---

REVIEW: http://review.gluster.org/11779 (tests: reset IFS after changing it)
posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2015-07-30 15:29:29 IST ---

REVIEW: http://review.gluster.org/11779 (tests: reset IFS after changing it)
posted (#2) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1245425
[Bug 1245425] IFS is not set back after used as "[" in log_newer function
of include.rc
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list