[Bugs] [Bug 1315639] New: Glusterfind hook script failing if /var/lib/glusterd/glusterfind dir was absent

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 8 10:01:51 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1315639

            Bug ID: 1315639
           Summary: Glusterfind hook script failing if
                    /var/lib/glusterd/glusterfind dir was absent
           Product: GlusterFS
           Version: 3.7.8
         Component: glusterfind
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
        QA Contact: bugs at gluster.org
                CC: avishwan at redhat.com, bugs at gluster.org,
                    khiremat at redhat.com
        Depends On: 1289935



+++ This bug was initially created as a clone of Bug #1289935 +++

Description of problem:
If during cleanup /var/lib/glusterd directory is deleted, glusterfind directory
will not be present. The cleanup script expects glusterfind directory to be
present.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Install Gluster, rm -rf /var/lib/glusterd except hooks directory. and
restart glusterd
2. Create a Volume
3. Delete Volume

Actual results:
Hook execution errors seen in glusterd logs.

[2015-11-11 13:03:41.906892] I [MSGID: 106495]
[glusterd-handler.c:3049:__glusterd_handle_getwd] 0-glusterd: Received getwd
req
[2015-11-11 13:03:41.910931] E [run.c:190:runner_log]
(-->/usr/lib64/glusterfs/3.7.5/xlator/mgmt/glusterd.so(+0xef3d2)
[0x7fc7d60923d2]
-->/usr/lib64/glusterfs/3.7.5/xlator/mgmt/glusterd.so(glusterd_hooks_run_hooks+0x470)
[0x7fc7d6092060] -->/usr/lib64/libglusterfs.so.0(runner_log+0x11e)
[0x7fc7e162868e] ) 0-management: Failed to execute script:
/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py
--volname=VOL_ZIMBRA 

Expected results:
No errors seen in Logs

Additional info:
When executed directly,

# /var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py
--volname=VOL_ZIMBRA
Traceback (most recent call last):
  File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py",
line 60, in <module>
    main()
  File "/var/lib/glusterd/hooks/1/delete/post/S57glusterfind-delete-post.py",
line 43, in main
    for session in os.listdir(glusterfind_dir):
OSError: [Errno 2] No such file or directory: '/var/lib/glusterd/glusterfind'

--- Additional comment from Vijay Bellur on 2015-12-09 06:43:18 EST ---

REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup
script on volume delete) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-10 05:00:11 EST ---

REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup
script on volume delete) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-24 23:36:14 EST ---

REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup
script on volume delete) posted (#3) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-29 00:58:18 EST ---

REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup
script on volume delete) posted (#4) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-02 06:48:25 EST ---

REVIEW: http://review.gluster.org/12923 (tools/glusterfind: Do not fail cleanup
script on volume delete) posted (#5) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-08 04:58:15 EST ---

COMMIT: http://review.gluster.org/12923 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 62047c80f541985bf9caa41336f471d95de3ce1c
Author: Aravinda VK <avishwan at redhat.com>
Date:   Wed Dec 9 17:09:42 2015 +0530

    tools/glusterfind: Do not fail cleanup script on volume delete

    If glusterfind dir is not present inside GLUSTERD_WORKDIR, then
    cleanup script Post Volume delete was failing. This patch safely
    handles the absence of glusterfind directory in GLUSTERD_WORKDIR

    BUG: 1289935
    Change-Id: I9f7e6035e3dc6079927803df942b0f921218c79a
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/12923
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kotresh HR <khiremat at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1289935
[Bug 1289935] Glusterfind hook script failing if
/var/lib/glusterd/glusterfind dir was absent
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list