[Bugs] [Bug 1315147] New: Peer probe from a reinstalled node should fail

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1315147

            Bug ID: 1315147
           Summary: Peer probe from a reinstalled node should fail
           Product: GlusterFS
           Version: 3.7.8
         Component: glusterd
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1311874



+++ This bug was initially created as a clone of Bug #1311874 +++

Description of problem:
In a two node cluster if one of the node goes through a re installation (say
N2) then once glusterd is restarted on this node the UUID is reinitialized. N1
to N2 handshake fails and peer status output on N2 still says peer rejected
which is correct behaviour. 

However, if user tries to probe N1 from N2, the peer probe goes through which
should have failed.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-02-25 04:22:53 EST ---

REVIEW: http://review.gluster.org/13519 (glusterd: reject peer probe from a
reinstalled node) posted (#1) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-25 22:50:39 EST ---

REVIEW: http://review.gluster.org/13519 (glusterd: reject peer probe from a
reinstalled node) posted (#2) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-02 23:16:47 EST ---

REVIEW: http://review.gluster.org/13519 (glusterd: reject peer probe from a
reinstalled node) posted (#3) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-04 07:10:31 EST ---

COMMIT: http://review.gluster.org/13519 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 85b9e8ebb89ecadd30a364853e1e7c706dcce968
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Feb 25 14:42:48 2016 +0530

    glusterd: reject peer probe from a reinstalled node

    In a cluster if a node (say N1) goes through a OS reinstallation then
probing
    some other node in the cluster from N1 doesn't fail as in
    gd_validate_mgmt_hndsk_req () uuid & hostname checks are done separately
but
    there should be one more check where both the conditions should meet.

    Steps to create the problem
    - N1 probes N2
    - bring down glusterd instance on N2
    - remove /var/lib/glusterd/* from N2
    - restart glusterd instance on N2
    - execute gluster peer probe N1 from N2

    Validations in gd_validate_mgmt_hndsk_req () has been improved to handle
this
    special case

    Change-Id: I3ba5d8e243bae07a7a6743d01b019e7014d39171
    BUG: 1311874
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/13519
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1311874
[Bug 1311874] Peer probe from a reinstalled node should fail
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.