[Bugs] [Bug 1315009] New: glusterd: coverity warning in glusterd-snapshot-utils.c copy_nfs_ganesha_file()

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1315009

            Bug ID: 1315009
           Summary: glusterd: coverity warning in
                    glusterd-snapshot-utils.c copy_nfs_ganesha_file()
           Product: GlusterFS
           Version: 3.7.8
         Component: glusterd
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kkeithle at redhat.com
                CC: bugs at gluster.org
        Depends On: 1310755



+++ This bug was initially created as a clone of Bug #1310755 +++

Description of problem:

coverity warning

Version-Release number of selected component (if applicable):

mainline, 3.7.x

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:



> ** CID 1351702:  Code maintainability issues  (UNUSED_VALUE)
> /data/workspace/gluster/glusterfs/xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c: 3695 in glusterd_copy_nfs_ganesha_file()
>
>
> ________________________________________________________________________________________________________
> *** CID 1351702:  Code maintainability issues  (UNUSED_VALUE)
> /data/workspace/gluster/glusterfs/xlators/mgmt/glusterd/src/glusterd-snapshot-utils.c: 3695 in glusterd_copy_nfs_ganesha_file()
> 3689     
> 3690             GF_VALIDATE_OR_GOTO (this->name, src_vol, out);
> 3691             GF_VALIDATE_OR_GOTO (this->name, dest_vol, out);
> 3692     
> 3693             if (src_vol->is_snap_volume) {
> 3694                     GLUSTERD_GET_SNAP_DIR (snap_dir, src_vol->snapshot, priv);
>>>>     CID 1351702:  Code maintainability issues  (UNUSED_VALUE)
>>>>     Assigning value from "snprintf(src_path, 4096UL, "%s/export.%s.conf", snap_dir, src_vol->snapshot->snapname)" to "ret" here, but that stored value is overwritten before it can be used.
> 3695                     ret = snprintf (src_path, sizeof (src_path),
> 3696                                     "%s/export.%s.conf", snap_dir,
> 3697                                     src_vol->snapshot->snapname);
> 3698             } else {
> 3699                     ret = snprintf (src_path, sizeof (src_path),
> 3700                                     "%s/export.%s.conf", GANESHA_EXPORT_DIRECTORY,

...

--- Additional comment from Vijay Bellur on 2016-02-22 11:06:38 EST ---

REVIEW: http://review.gluster.org/13486 (glusterd: coverity warning in
glusted_copy_nfs_ganesha_file()) posted (#1) for review on master by Kaleb
KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-22 13:14:37 EST ---

REVIEW: http://review.gluster.org/13486 (glusterd: coverity warning in
glusted_copy_nfs_ganesha_file()) posted (#2) for review on master by Kaleb
KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-23 11:45:03 EST ---

COMMIT: http://review.gluster.org/13486 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit ec6eb8200e41dadc623fd2341a3c5cf8cc71dec7
Author: Kaleb S KEITHLEY <kkeithle at redhat.com>
Date:   Mon Feb 22 11:02:31 2016 -0500

    glusterd: coverity warning in glusted_copy_nfs_ganesha_file()

    fix unused return value from snprintf.

    Also minor cleanup, including safe handling of truncated output by
    snprintf.

    Change-Id: Ibec8c7e6cc4ef07b6535d01a0719359fa3ef8030
    BUG: 1310755
    Signed-off-by: Kaleb S KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: http://review.gluster.org/13486
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1310755
[Bug 1310755] glusterd: coverity warning in glusterd-snapshot-utils.c
copy_nfs_ganesha_file()
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.