[Bugs] [Bug 1313309] New: Handle Rsync/Tar errors effectively

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1313309

            Bug ID: 1313309
           Summary: Handle Rsync/Tar errors effectively
           Product: GlusterFS
           Version: 3.7.8
         Component: geo-replication
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: bugs at gluster.org
        Depends On: 1287723



+++ This bug was initially created as a clone of Bug #1287723 +++

Description of problem:
When Changelogs processed in Batch, Geo-rep logs all the GFIDs from that batch
as SKIPPED even when a few GFIDs from the batch failed to sync.


Steps to Reproduce: (Reproduced by introducing GFID conflict)
1. Create a file in Slave mount(say f1)
2. Create files in Master mount and add data to it
   echo "Hello" > f1; echo "Hello" > f2; echo "Hello" > f3;
3. All the files Create and Data will be recorded in single changelog.
Rsync/Tar skips f1 but syncs f2 and f3. But it logs GFIDs of f1, f2 and f3 as
SKIPPED.

Actual results:
Logs all the GFIDs as failure.

Expected results:
Only failures should be reported in log.

--- Additional comment from Vijay Bellur on 2015-12-02 09:28:22 EST ---

REVIEW: http://review.gluster.org/12856 (geo-rep: Handling Rsync/Tar errors
efficiently) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2015-12-02 09:35:39 EST ---

REVIEW: http://review.gluster.org/12856 (geo-rep: Handling Rsync/Tar errors
efficiently) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-02-26 05:15:14 EST ---

COMMIT: http://review.gluster.org/12856 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit d136a789258e8f600e536717da156a242d8ed9a5
Author: Aravinda VK <avishwan at redhat.com>
Date:   Wed Dec 2 19:37:55 2015 +0530

    geo-rep: Handling Rsync/Tar errors efficiently

    Geo-rep processes Changelogs in Batch, if one file in batch
    fails with rsync error that Changelog file is reprocessed multiple times.
    After MAX_RETRY, it logs all the GFIDs from that batch as Skipped.

    This patch addresses following issues,
    1. When Rsync/Tar fails do not parse Changelog again for retry
    2. When Rsync/Tar fails do not replay Entry operations, only retry
       rsync/tar for those GFIDs
    3. Log Error in Rsync/Tar only in the last Retry
    4. Do not log Skipped GFIDs since Rsync/Tar errors are logged for
       only failed files.
    5. Changed Entry failures as Error instead of Warning

    BUG: 1287723
    Change-Id: Ie134ce2572693056ab9b9008cd8aa5b5d87f7975
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/12856
    Reviewed-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-by: Saravanakumar Arumugam <sarumuga at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1287723
[Bug 1287723] Handle Rsync/Tar errors effectively
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.