[Bugs] [Bug 1351139] New: The volume option "nfs.enable-ino32" should be a per volume one, not global

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1351139

            Bug ID: 1351139
           Summary: The volume option "nfs.enable-ino32" should be a per
                    volume one, not global
           Product: GlusterFS
           Version: mainline
         Component: nfs
          Keywords: EasyFix, FutureFeature, Triaged
          Severity: high
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org
            Blocks: 1350851



Description of problem:

Volume option, "nfs.enable-ino32" behaving as a global option for all volumes
instead providing a single volume for setting the volume option,

[root at node1 ~]# gluster volume set test nfs.enable-ino32 on
volume set: success

[root at node1 ~]# gluster volume info |grep "nfs.enable-ino32"
nfs.enable-ino32: on
nfs.enable-ino32: on
nfs.enable-ino32: on
nfs.enable-ino32: on

Version-Release number of selected component (if applicable):
all

How reproducible:
Always

Steps to Reproduce
1. Create a few volumes, type does not matter
2. Set the volume option, 

    # gluster v set test nfs.enable-ino32 on


Actual results:
Volume option is setting as a global option for all the volume's.

Expected results:
Volume option should set for single volume.

Additional info:
The change that is needed would be similar to the "nfs.disable" option. The
enable_ino32 boolean will need to move from the nfs_state structure to
nfs3_state. nfs3_iatt_gfid_to_ino() can then get a 2nd argument "gf_boolean
ino32".

I see this as an EasyFix, a new contributor should be able to implement the
changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.