[Bugs] [Bug 1351024] New: Implement API to get page aligned iobufs in iobuf.c

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1351024

            Bug ID: 1351024
           Summary: Implement API to get page aligned iobufs in iobuf.c
           Product: GlusterFS
           Version: 3.7.12
         Component: core
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1343838



+++ This bug was initially created as a clone of Bug #1343838 +++

Description of problem:

One of the consumers of a page aligned buffer would be posix's readv fop on
O_DIRECT fds. Today the way it works is by getting a page-aligned buffer
through calloc, pread()ing into this buffer and then copying its contents into
a newly created iobuf's ptr. This results in an extra memcpy() which can be
avoided if we could implement an api that would return an iobuf whose ptr is
mem-aligned. That way the iobuf->ptr can be directly passed to sys_preadv() as
a parameter by posix translator.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-06-08 07:16:33 EDT ---

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that
provides page-aligned iobufs) posted (#1) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-08 22:33:49 EDT ---

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that
provides page-aligned iobufs) posted (#2) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-09 05:34:35 EDT ---

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that
provides page-aligned iobufs) posted (#3) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-28 17:52:46 EDT ---

COMMIT: http://review.gluster.org/14672 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 1e60f9746cf7cb8ce34e2b1572410c39b11d7664
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Tue Jun 7 16:27:34 2016 +0530

    libglusterfs: Implement API that provides page-aligned iobufs

    One of the consumers of a page aligned buffer would be posix's
    readv fop on O_DIRECT fds. Today the way it works is by getting
    a page-aligned buffer through calloc, pread()ing into this buffer
    and then copying its contents into a newly created iobuf's ptr.
    This results in an extra memcpy() which can be avoided if we could
    implement an api that would return an iobuf whose ptr is
    page-aligned. That way the iobuf->ptr can be directly passed to
    sys_pread() as a parameter by posix translator.

    Change-Id: I385139bc6ee309fc501034b3af8f7814fab8cd65
    BUG: 1343838
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/14672
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Zhou Zhengping <johnzzpcrystal at gmail.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1343838
[Bug 1343838] Implement API to get page aligned iobufs in iobuf.c
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.