[Bugs] [Bug 1350787] New: gfapi: in case of handle based APIs, close glfd after successful create

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 28 12:00:05 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1350787

            Bug ID: 1350787
           Summary: gfapi: in case of handle based APIs, close glfd after
                    successful create
           Product: GlusterFS
           Version: 3.8.0
         Component: libgfapi
          Keywords: Triaged
          Severity: medium
          Assignee: jthottan at redhat.com
          Reporter: jthottan at redhat.com
        QA Contact: sdharane at redhat.com
                CC: bugs at gluster.org, sdharane at redhat.com,
                    skoduri at redhat.com
        Depends On: 1339553
            Blocks: 1334907



+++ This bug was initially created as a clone of Bug #1339553 +++

Description of problem:

In gfapi, we create and associate a (gl)fd during creation of any file. But in
case of handleops, since application is interested in handle (glfs_object),
this
(gl)fd is not passed to application resulting in a leak. The fix is to close it
after successful create.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-25 06:02:23 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after
create) posted (#1) for review on master by soumya k (skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-02 03:24:31 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after
create) posted (#2) for review on master by jiffin tony Thottan
(jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-09 03:21:06 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after
create) posted (#3) for review on master by jiffin tony Thottan
(jthottan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-27 06:12:54 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Close glfd after
create) posted (#4) for review on master by soumya k (skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-27 07:36:10 EDT ---

REVIEW: http://review.gluster.org/14532 (gfapi/handleops: Avoid using glfd
during create) posted (#5) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-28 07:22:15 EDT ---

COMMIT: http://review.gluster.org/14532 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 763ed1017b0011934ad2414d7396c46e528ea5b3
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Wed May 25 14:38:31 2016 +0530

    gfapi/handleops: Avoid using glfd during create

    To avoid leaking glfd while creating a file using handleops and
    since application shall not be interested in it, use the 'fd'
    object directly which can be un'refed post create.

    Change-Id: I119874ffb63fb4aa18f846ba1fdbe77874b66a54
    BUG: 1339553
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/14532
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1334907
[Bug 1334907] [Perf] : Poor large file read/write performance on Ganesha
mounts
https://bugzilla.redhat.com/show_bug.cgi?id=1339553
[Bug 1339553] gfapi: in case of handle based APIs, close glfd after
successful create
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ysaFJWKfIR&a=cc_unsubscribe


More information about the Bugs mailing list