[Bugs] [Bug 1350477] Test to check if the maintainer reviewed the patch

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1350477

Jeff Darcy <jdarcy at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdarcy at redhat.com



--- Comment #1 from Jeff Darcy <jdarcy at redhat.com> ---
There are at least three special cases that we need to make sure are handled.

(1) A patch that touches multiple maintainers' areas.  Sometimes it's useful to
have both maintainer A and maintainer B fully review the patch (or at least
their respective parts).  Other times, it might be sufficient for A *or* B to
review it.  How should we handle these?

(2) Overlaps and overrides.  Sometimes, the maintainers for large components
get overwhelmed.  In these cases, I think it's necessary for the project-level
architects (such as myself) to sign off on patches in their stead.  Obviously
some discretion is required, but as one of those project-level architects I
might object if I found that the system wouldn't *let* me help in this way.

(3) Mis-assigned ownership.  Some files, or even parts of files, are really
owned by someone other than the maintainer for that file hierarchy.  For
example, there are fairly large swaths of code in CLI or glusterd that really
belong to tiering or geo-rep and should be reviewed by those features'
maintainers instead.  Snapshot functionality is spread all over other
components.  Again, it seems like some sort of override capability is needed,
to indicate that the reviews are sufficient even if they don't include the
nominal maintainer for those files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bpv2pShjEo&a=cc_unsubscribe