[Bugs] [Bug 1346751] Unsafe access to inode->fd_list

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1346751



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14734 committed in release-3.7 by Kaushal M
(kaushal at redhat.com) 
------
commit ed16cfb0455e41ee39addf6b3cdacdbe0d98308a
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Thu Jun 9 16:53:19 2016 +0200

    cluster/dht: Fix unsafe iteration on inode->fd_list

    When DHT traverses the inode->fd_list, it does that in an unsafe
    way that can generate races with fd_unref() called from other threads.

    This patch fixes this problem taking the inode->lock and adding a
    reference to the fd while it's being used outside of the mutex
    protected region.

    A minor change in storage/posix has been done to also access the
    inode->fd_list in a safe way.

    Backport of:
    > Change-Id: I10d469ca6a8f76e950a8c9779ae9c8b70f88ef93
    > BUG: 1344340
    > Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    > Reviewed-on: http://review.gluster.org/14682
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

    Change-Id: I10d469ca6a8f76e950a8c9779ae9c8b70f88ef93
    BUG: 1346751
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/14734
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ntpB12j6XV&a=cc_unsubscribe