[Bugs] [Bug 1343362] Input / Output when chmoding files on NFS mount point

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1343362



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14659 committed in release-3.7 by Kaushal M
(kaushal at redhat.com) 
------
commit c04ee47d1e9847b50c459734a42681450005ee60
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Mon Jun 6 18:10:09 2016 +0530

    nfs : store sattr properly in nfs3_setattr() call

    nfs3_setattr stores the input arguments in cs->stbuf.
    However, inode/entry resolution code overwrites cs->stbuf
    after a successful resolution, thereby overwriting the
    input arguments with iatt values stored on backend.
    Hence operations like chmod/chown turns out to be a NOP.
    Specifically following are the functions that overwrite
    cs->stbuf:

        nfs3_fh_resolve_inode_lookup_cbk
        nfs3_fh_resolve_entry_lookup_cbk

    Since we resort to inode resolution only when inode is not
    found in inode table and lru limit guards the number of
    inodes in itable, we run into this issue only when the data
    set is bigger than lru limit of itable.

    Fix is to store input arguments in a member other than
    cs->stbuf.

    Thanks Du for suggesting the fix

            Backport of http://review.gluster.org/#/c/14657/

    > Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
    > BUG: 1318204
    > Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    > Signed-off-by: Manikandan Selvaganesh <mselvaga at redhat.com>

    Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
    BUG: 1343362
    Signed-off-by: Manikandan Selvaganesh <mselvaga at redhat.com>
    Reviewed-on: http://review.gluster.org/14659
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GUd4ibK6cH&a=cc_unsubscribe