[Bugs] [Bug 1348056] New: cli core dumped while providing/ not wrong values during arbiter replica volume

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1348056

            Bug ID: 1348056
           Summary: cli  core dumped while providing/not wrong values
                    during arbiter replica volume
           Product: GlusterFS
           Version: 3.7.12
         Component: arbiter
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: aspandey at redhat.com, bugs at gluster.org,
                    ravishankar at redhat.com
        Depends On: 1346821
            Blocks: 1348055



+++ This bug was initially created as a clone of Bug #1346821 +++

Description of problem:

[root at dhcp43-153 ~]# gluster v create rep arbiter 3
10.70.43.153:/rhs/brick{1..3}/brick force
gluster: cli-cmd-parser.c:632: cli_cmd_volume_create_parse: Assertion `!"opword
mismatch"' failed.
Aborted (core dumped)
[root at dhcp43-153 ~]# 


Version-Release number of selected component (if applicable):
glusterfs --version
glusterfs 3.9dev built on Jun  8 2016 14:50:20
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2013 Red Hat, Inc. <http://www.redhat.com/>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
It is licensed to you under your choice of the GNU Lesser
General Public License, version 3 or any later version (LGPLv3
or later), or the GNU General Public License, version 2 (GPLv2),
in all cases as published by the Free Software Foundation.


How reproducible:
100%

Steps to Reproduce: 
Don't give "replica 3" 
1. gluster v create rep arbiter 3 10.70.43.153:/rhs
2. 
3.

Actual results:
core dumped

Expected results:
It should display a message with correct usage help.

Additional info:

--- Additional comment from Ravishankar N on 2016-06-15 10:15:36 EDT ---

Are you working on the fix Ashish?

--- Additional comment from Ashish Pandey on 2016-06-15 14:37:25 EDT ---


No, I just raised this bug and continued to reproduce other bug on which I was
working and found this.

--- Additional comment from Ravishankar N on 2016-06-15 21:01:35 EDT ---

Okay.

--- Additional comment from Vijay Bellur on 2016-06-16 00:55:49 EDT ---

REVIEW: http://review.gluster.org/14738 (cli: fix crash in arbiter keyword
parsing) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-17 03:29:16 EDT ---

REVIEW: http://review.gluster.org/14738 (cli: fix crash in arbiter keyword
parsing) posted (#2) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-17 06:56:43 EDT ---

COMMIT: http://review.gluster.org/14738 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit b5c492dfea2d2e2075aa88d7153fba57b06e739d
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Thu Jun 16 10:21:53 2016 +0530

    cli: fix crash in arbiter keyword parsing

    A negative case like `gluster volume create volname arbiter 3
/bricks{1..3}`
    must not crash. 'arbiter' keyword is valid only for (3 way) replica
volumes.

    The .t that is added will crash and create a core *without* the fix when
    run but will still pass all TESTs. Since the regression framework fails
    the .t if it creates a core,  we can consider it a valid test 'that
    fails without the fix'.

    Change-Id: Ie2d7ced66025ea3617d30f6f823b22401e6d2fde
    BUG: 1346821
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/14738
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1346821
[Bug 1346821] cli  core dumped while providing/not wrong values during
arbiter replica volume
https://bugzilla.redhat.com/show_bug.cgi?id=1348055
[Bug 1348055] cli  core dumped while providing/not wrong values during
arbiter replica volume
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.