[Bugs] [Bug 1347553] New: O_DIRECT support for sharding

bugzilla at redhat.com bugzilla at redhat.com
Fri Jun 17 08:37:45 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1347553

            Bug ID: 1347553
           Summary: O_DIRECT support for sharding
           Product: GlusterFS
           Version: 3.8.0
         Component: sharding
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: pkarampu at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org, kdhananj at redhat.com
        Depends On: 1342171
            Blocks: 1342903



+++ This bug was initially created as a clone of Bug #1342171 +++

Description of problem:

This bug is to track work towards making odirect writes and reads work at the
level of individual shards.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-06-02 11:30:01 EDT ---

REVIEW: http://review.gluster.org/14191 (core, shard: Make shards inherit main
file's O_DIRECT flag if present) posted (#7) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-03 05:32:56 EDT ---

REVIEW: http://review.gluster.org/14191 (core, shard: Make shards inherit main
file's O_DIRECT flag if present) posted (#8) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-03 05:32:59 EDT ---

REVIEW: http://review.gluster.org/14639 (posix, shard: Use page-aligned buffer
for o-direct reads) posted (#1) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-03 06:11:08 EDT ---

REVIEW: http://review.gluster.org/14191 (core, shard: Make shards inherit main
file's O_DIRECT flag if present) posted (#9) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-03 06:11:11 EDT ---

REVIEW: http://review.gluster.org/14639 (posix, shard: Use page-aligned buffer
for o-direct reads) posted (#2) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-03 21:58:14 EDT ---

COMMIT: http://review.gluster.org/14639 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 9e0cdf1d2393d7bdb0eac019e70dce7c5f4f59c9
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Thu Jun 2 19:45:03 2016 +0530

    posix, shard: Use page-aligned buffer for o-direct reads

    and also make shard_readv_do() pass the correct flags when
    the original fd is opened with O_DIRECT.

    Change-Id: Ic2f8ad900743ed3f7cab56948bcf1358d247a311
    BUG: 1342171
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/14639
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

--- Additional comment from Vijay Bellur on 2016-06-06 13:58:22 EDT ---

REVIEW: http://review.gluster.org/14191 (core, shard: Make shards inherit main
file's O_DIRECT flag if present) posted (#10) for review on master by Pranith
Kumar Karampuri (pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-06 15:01:27 EDT ---

REVIEW: http://review.gluster.org/14191 (core, shard: Make shards inherit main
file's O_DIRECT flag if present) posted (#11) for review on master by Pranith
Kumar Karampuri (pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-07 03:19:32 EDT ---

COMMIT: http://review.gluster.org/14191 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit eb1744582d57d0f9fe08275781800c0c3459697f
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Mon May 2 16:51:10 2016 +0530

    core, shard: Make shards inherit main file's O_DIRECT flag if present

    If the application opens a file with O_DIRECT, the shards'
    anon fds would also need to inherit the flag. Towards this,
    shard xl would be passing the odirect flag in the @flags parameter
    to the WRITEV fop. This will be used in anon fd resolution
    and subsequent opening by posix xl.

    Change-Id: Iddb75c9ed14ce5a8c5d2128ad09b749f46e3b0c2
    BUG: 1342171
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/14191
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

--- Additional comment from Vijay Bellur on 2016-06-07 08:40:40 EDT ---

REVIEW: http://review.gluster.org/14665 (libglusterfs: Negate all but O_DIRECT
flag if present on anon fds) posted (#1) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-08 22:53:22 EDT ---

REVIEW: http://review.gluster.org/14665 (libglusterfs: Negate all but O_DIRECT
flag if present on anon fds) posted (#2) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-09 05:29:26 EDT ---

REVIEW: http://review.gluster.org/14665 (libglusterfs: Negate all but O_DIRECT
flag if present on anon fds) posted (#3) for review on master by Krutika
Dhananjay (kdhananj at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-10 01:05:52 EDT ---

COMMIT: http://review.gluster.org/14665 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 79dfe7d197ced45bd3b84f71d5c889e95f4dec1a
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Tue Jun 7 17:15:56 2016 +0530

    libglusterfs: Negate all but O_DIRECT flag if present on anon fds

    This is to prevent any unforeseen problems that might arise due to
    writevs and readvs being wound with @flag parameter containing
    O_TRUNC or O_APPEND especially wrt translators like sharding and ec
    where O_TRUNC write or O_APPEND write on individual shards/fragments
    is not the same as O_TRUNC write or O_APPEND write as expected by the
    application.

    Change-Id: I9e5206a6ce2b1b70df61ff23b1c961cf25bf7ff9
    BUG: 1342171
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/14665
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1342171
[Bug 1342171] O_DIRECT support for sharding
https://bugzilla.redhat.com/show_bug.cgi?id=1342903
[Bug 1342903] O_DIRECT support for sharding
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list