[Bugs] [Bug 1346156] New: Possible crash due to a timer cancellation race

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 14 06:47:15 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1346156

            Bug ID: 1346156
           Summary: Possible crash due to a timer cancellation race
           Product: GlusterFS
           Version: 3.7.11
         Component: disperse
          Keywords: Triaged
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: xhernandez at datalab.es
                CC: bugs at gluster.org
        Depends On: 1345855



+++ This bug was initially created as a clone of Bug #1345855 +++

Description of problem:

Incorrect management of timers failed to be cancelled could lead to crashes
when the timer callback is executed and some resources have already been
released by the cancelling thread.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-06-13 12:47:26 CEST ---

REVIEW: http://review.gluster.org/14712 (cluster/ec: Fix race in timer
cancellation) posted (#1) for review on master by Xavier Hernandez
(xhernandez at datalab.es)

--- Additional comment from Vijay Bellur on 2016-06-13 12:49:57 CEST ---

REVIEW: http://review.gluster.org/14712 (cluster/ec: Fix race in timer
cancellation) posted (#2) for review on master by Xavier Hernandez
(xhernandez at datalab.es)

--- Additional comment from Vijay Bellur on 2016-06-13 13:40:39 CEST ---

REVIEW: http://review.gluster.org/14712 (cluster/ec: Fix race in timer
cancellation) posted (#3) for review on master by Xavier Hernandez
(xhernandez at datalab.es)

--- Additional comment from Vijay Bellur on 2016-06-14 03:03:24 CEST ---

COMMIT: http://review.gluster.org/14712 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit fb013a9db2cc019d36b07644f24e6c15ed39725c
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Mon Jun 13 12:42:47 2016 +0200

    cluster/ec: Fix race in timer cancellation

    A race in timer cancellation for delayed unlock could cause a crash
    if the cancelling thread fails to cancel the timer because it has
    already been fired but not executed, and the callback is scheduled
    out of the CPU, delaying it until the thread has released important
    resources needed by the callback.

    This patch improves the handling of this case to make it robust.

    Change-Id: I5c8a8c6610c5136f71b938aa78b5878ba05238d4
    BUG: 1345855
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/14712
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1345855
[Bug 1345855] Possible crash due to a timer cancellation race
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list