[Bugs] [Bug 1344396] fd leak in disperse

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1344396



--- Comment #5 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14683 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit e0b057cf28abc534f1fc74f4ea921c78a52ab6fe
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Thu Jun 9 17:29:26 2016 +0200

    cluster/ec: Fix invalid __fd_unref() call

    __fd_unref() doesn't do any cleanup, so it cannot be called to release
    fd references, specially if it's the last reference.

    The code has been changed to avoid a call to this function.

    In the previous version we always tried to keep the newest fd in the
    ec_lock_t structure. However this is not necessary. We'll always keep
    one reference to an open file on the same inode. It's irrelevant if
    the reference is new or old.

    The function __fd_unref() has also been removed from fd.h to avoid being
    used in the future since it's useless as it's defined now.

    Change-Id: Ia728777fc8e464758d5ea4d3bf020f0603919039
    BUG: 1344396
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/14683
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Ashish Pandey <aspandey at redhat.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fQmbOlbkdY&a=cc_unsubscribe