[Bugs] [Bug 1318204] Input / Output when chmoding files on NFS mount point

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 7 11:37:49 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1318204



--- Comment #7 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14657 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 093902319ccc3d6bbb954fc40944a9e23aa68344
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Mon Jun 6 18:10:09 2016 +0530

    nfs : store sattr properly in nfs3_setattr() call

    nfs3_setattr stores the input arguments in cs->stbuf.
    However, inode/entry resolution code overwrites cs->stbuf
    after a successful resolution, thereby overwriting the
    input arguments with iatt values stored on backend.
    Hence operations like chmod/chown turns out to be a NOP.
    Specifically following are the functions that overwrite
    cs->stbuf:

        nfs3_fh_resolve_inode_lookup_cbk
        nfs3_fh_resolve_entry_lookup_cbk

    Since we resort to inode resolution only when inode is not
    found in inode table and lru limit guards the number of
    inodes in itable, we run into this issue only when the data
    set is bigger than lru limit of itable.

    Fix is to store input arguments in a member other than
    cs->stbuf.

    Thanks Du for suggesting the fix

    Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939
    BUG: 1318204
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/14657
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: Atin Mukherjee <amukherj at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: soumya k <skoduri at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Tested-by: Kaleb KEITHLEY <kkeithle at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rJUnLwjvDQ&a=cc_unsubscribe


More information about the Bugs mailing list