[Bugs] [Bug 1331704] Review Request: glusterfs-coreutils - Mimics standard Linux coreutils for GlusterFS clusters

bugzilla at redhat.com bugzilla at redhat.com
Wed Jun 1 14:33:10 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1331704



--- Comment #2 from Anoop C S <anoopcs at redhat.com> ---
review.txt
==========

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Provides: bundled(gnulib) in place as required.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
     generated". 15 files have unknown license. Detailed output of
     licensecheck is given towars the end.
[-]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see below).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see below).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     glusterfs-coreutils-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see below).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: glusterfs-coreutils-0.0.1-0.4.git60d57d8.fc25.x86_64.rpm
          glusterfs-coreutils-debuginfo-0.0.1-0.4.git60d57d8.fc25.x86_64.rpm
          glusterfs-coreutils-0.0.1-0.4.git60d57d8.fc25.src.rpm
glusterfs-coreutils.x86_64: W: spelling-error %description -l en_US gluster ->
fluster, glister, luster
glusterfs-coreutils.x86_64: W: spelling-error %description -l en_US mkdir ->
Dirk
glusterfs-coreutils.src: W: spelling-error %description -l en_US gluster ->
fluster, glister, luster
glusterfs-coreutils.src: W: spelling-error %description -l en_US mkdir -> Dirk
glusterfs-coreutils.src:16: W: unversioned-explicit-provides bundled(gnulib)
glusterfs-coreutils.src: W: invalid-url Source0:
glusterfs-coreutils-60d57d8.tar.gz
3 packages and 0 specfiles checked; 0 errors, 6 warnings.


Rpmlint (debuginfo)
-------------------
Checking: glusterfs-coreutils-debuginfo-0.0.1-0.4.git60d57d8.fc25.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
glusterfs-coreutils.x86_64: W: spelling-error %description -l en_US gluster ->
fluster, glister, luster
glusterfs-coreutils.x86_64: W: spelling-error %description -l en_US mkdir ->
Dirk
2 packages and 0 specfiles checked; 0 errors, 2 warnings.


Requires
--------
glusterfs-coreutils-debuginfo (rpmlib, GLIBC filtered):

glusterfs-coreutils (rpmlib, GLIBC filtered):
    glusterfs-api
    libacl.so.1()(64bit)
    libc.so.6()(64bit)
    libgfapi.so.0()(64bit)
    libgfapi.so.0(GFAPI_3.4.0)(64bit)
    libgfapi.so.0(GFAPI_3.5.0)(64bit)
    libgfrpc.so.0()(64bit)
    libgfxdr.so.0()(64bit)
    libglusterfs.so.0()(64bit)
    libreadline.so.6()(64bit)
    libuuid.so.1()(64bit)
    rtld(GNU_HASH)


Provides
--------
glusterfs-coreutils-debuginfo:
    glusterfs-coreutils-debuginfo
    glusterfs-coreutils-debuginfo(x86-64)

glusterfs-coreutils:
    bundled(gnulib)
    glusterfs-coreutils
    glusterfs-coreutils(x86-64)

Source checksums
----------------
Using local file glusterfs-coreutils-60d57d8.tar.gz as upstream
file:glusterfs-coreutils-60d57d8.tar.gz :
  CHECKSUM(SHA256) this package     :
80e2646f03d0b203a4665acaa65b7dcf9f201a62edd2c01a57f110efb184ba29
  CHECKSUM(SHA256) upstream package :
80e2646f03d0b203a4665acaa65b7dcf9f201a62edd2c01a57f110efb184ba29


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -n glusterfs-coreutils -m
fedora-rawhide-x86_64 -o=--dnf
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


licensecheck.txt
================

GPL (v3 or later)
-----------------
glusterfs-coreutils-60d57d8/lib/argmatch.c
glusterfs-coreutils-60d57d8/lib/argmatch.h
glusterfs-coreutils-60d57d8/lib/assure.h
glusterfs-coreutils-60d57d8/lib/c-ctype.h
glusterfs-coreutils-60d57d8/lib/c-strcase.h
glusterfs-coreutils-60d57d8/lib/c-strcasecmp.c
glusterfs-coreutils-60d57d8/lib/c-strcaseeq.h
glusterfs-coreutils-60d57d8/lib/c-strncasecmp.c
glusterfs-coreutils-60d57d8/lib/errno.in.h
glusterfs-coreutils-60d57d8/lib/error.c
glusterfs-coreutils-60d57d8/lib/error.h
glusterfs-coreutils-60d57d8/lib/exitfail.c
glusterfs-coreutils-60d57d8/lib/exitfail.h
glusterfs-coreutils-60d57d8/lib/getopt.c
glusterfs-coreutils-60d57d8/lib/getopt.in.h
glusterfs-coreutils-60d57d8/lib/getopt1.c
glusterfs-coreutils-60d57d8/lib/getopt_int.h
glusterfs-coreutils-60d57d8/lib/gettext.h
glusterfs-coreutils-60d57d8/lib/human.c
glusterfs-coreutils-60d57d8/lib/human.h
glusterfs-coreutils-60d57d8/lib/intprops.h
glusterfs-coreutils-60d57d8/lib/inttypes.in.h
glusterfs-coreutils-60d57d8/lib/localcharset.c
glusterfs-coreutils-60d57d8/lib/localcharset.h
glusterfs-coreutils-60d57d8/lib/locale.in.h
glusterfs-coreutils-60d57d8/lib/localeconv.c
glusterfs-coreutils-60d57d8/lib/mbrtowc.c
glusterfs-coreutils-60d57d8/lib/mbsinit.c
glusterfs-coreutils-60d57d8/lib/msvc-inval.c
glusterfs-coreutils-60d57d8/lib/msvc-inval.h
glusterfs-coreutils-60d57d8/lib/msvc-nothrow.c
glusterfs-coreutils-60d57d8/lib/msvc-nothrow.h
glusterfs-coreutils-60d57d8/lib/quote.h
glusterfs-coreutils-60d57d8/lib/quotearg.c
glusterfs-coreutils-60d57d8/lib/quotearg.h
glusterfs-coreutils-60d57d8/lib/stdbool.in.h
glusterfs-coreutils-60d57d8/lib/stddef.in.h
glusterfs-coreutils-60d57d8/lib/stdint.in.h
glusterfs-coreutils-60d57d8/lib/stdio.in.h
glusterfs-coreutils-60d57d8/lib/stdlib.in.h
glusterfs-coreutils-60d57d8/lib/streq.h
glusterfs-coreutils-60d57d8/lib/strerror-override.c
glusterfs-coreutils-60d57d8/lib/strerror-override.h
glusterfs-coreutils-60d57d8/lib/strerror.c
glusterfs-coreutils-60d57d8/lib/string.in.h
glusterfs-coreutils-60d57d8/lib/strtoimax.c
glusterfs-coreutils-60d57d8/lib/strtol.c
glusterfs-coreutils-60d57d8/lib/strtoul.c
glusterfs-coreutils-60d57d8/lib/strtoull.c
glusterfs-coreutils-60d57d8/lib/sys_types.in.h
glusterfs-coreutils-60d57d8/lib/unistd.in.h
glusterfs-coreutils-60d57d8/lib/verify.h
glusterfs-coreutils-60d57d8/lib/wchar.in.h
glusterfs-coreutils-60d57d8/lib/wctype.in.h
glusterfs-coreutils-60d57d8/lib/xalloc-die.c
glusterfs-coreutils-60d57d8/lib/xalloc-oversized.h
glusterfs-coreutils-60d57d8/lib/xalloc.h
glusterfs-coreutils-60d57d8/lib/xmalloc.c
glusterfs-coreutils-60d57d8/lib/xstrtol-error.c
glusterfs-coreutils-60d57d8/lib/xstrtol.c
glusterfs-coreutils-60d57d8/lib/xstrtol.h
glusterfs-coreutils-60d57d8/snippet/arg-nonnull.h
glusterfs-coreutils-60d57d8/snippet/c++defs.h
glusterfs-coreutils-60d57d8/snippet/warn-on-use.h
glusterfs-coreutils-60d57d8/src/glfs-cat.c
glusterfs-coreutils-60d57d8/src/glfs-cat.h
glusterfs-coreutils-60d57d8/src/glfs-cli-commands.c
glusterfs-coreutils-60d57d8/src/glfs-cli-commands.h
glusterfs-coreutils-60d57d8/src/glfs-cli.c
glusterfs-coreutils-60d57d8/src/glfs-cli.h
glusterfs-coreutils-60d57d8/src/glfs-cp.c
glusterfs-coreutils-60d57d8/src/glfs-cp.h
glusterfs-coreutils-60d57d8/src/glfs-flock.c
glusterfs-coreutils-60d57d8/src/glfs-flock.h
glusterfs-coreutils-60d57d8/src/glfs-ls.c
glusterfs-coreutils-60d57d8/src/glfs-ls.h
glusterfs-coreutils-60d57d8/src/glfs-mkdir.c
glusterfs-coreutils-60d57d8/src/glfs-mkdir.h
glusterfs-coreutils-60d57d8/src/glfs-put.c
glusterfs-coreutils-60d57d8/src/glfs-rm.c
glusterfs-coreutils-60d57d8/src/glfs-rm.h
glusterfs-coreutils-60d57d8/src/glfs-stat-util.c
glusterfs-coreutils-60d57d8/src/glfs-stat-util.h
glusterfs-coreutils-60d57d8/src/glfs-stat.c
glusterfs-coreutils-60d57d8/src/glfs-stat.h
glusterfs-coreutils-60d57d8/src/glfs-tail.c
glusterfs-coreutils-60d57d8/src/glfs-tail.h
glusterfs-coreutils-60d57d8/src/glfs-util.c
glusterfs-coreutils-60d57d8/src/glfs-util.h

MIT/X11 (BSD like)
------------------
glusterfs-coreutils-60d57d8/install-sh

Unknown or generated
--------------------
glusterfs-coreutils-60d57d8/COPYING
glusterfs-coreutils-60d57d8/TODO
glusterfs-coreutils-60d57d8/ar-lib
glusterfs-coreutils-60d57d8/compile
glusterfs-coreutils-60d57d8/configure
glusterfs-coreutils-60d57d8/depcomp
glusterfs-coreutils-60d57d8/lib/c-ctype.c
glusterfs-coreutils-60d57d8/lib/strtoumax.c
glusterfs-coreutils-60d57d8/lib/unistd.c
glusterfs-coreutils-60d57d8/lib/wctype-h.c
glusterfs-coreutils-60d57d8/lib/xstrtoul.c
glusterfs-coreutils-60d57d8/lib/xstrtoumax.c
glusterfs-coreutils-60d57d8/ltmain.sh
glusterfs-coreutils-60d57d8/missing
glusterfs-coreutils-60d57d8/snippet/_Noreturn.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F2AELXyBYO&a=cc_unsubscribe


More information about the Bugs mailing list