[Bugs] [Bug 1341556] New: [features/worm] Unwind FOPs with op_errno and add gf_worm prefix to functions

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1341556

            Bug ID: 1341556
           Summary: [features/worm] Unwind FOPs with op_errno and add
                    gf_worm prefix to functions
           Product: GlusterFS
           Version: 3.8.0
         Component: unclassified
          Assignee: bugs at gluster.org
          Reporter: ksubrahm at redhat.com
                CC: bugs at gluster.org, josferna at redhat.com,
                    rtalur at redhat.com, smohan at redhat.com



+++ This bug was initially created as a clone of Bug #1333263 +++

Description of problem:

1.In the worm translator the FOPs are being unwinded using the errno -1. This
should be replaced with the op_errno and assigning the proper error numbers to
that.
2.Some of the functions in worm-helper.c should have gf_worm prefix so that
they will not clash with any other functions.
The functions in worm.c should be static.

Version-Release number of selected component (if applicable):
Glsuterfs3.8.0




Additional info:
Requesting for review.

--- Additional comment from Vijay Bellur on 2016-05-05 03:18:01 EDT ---

REVIEW: http://review.gluster.org/14222 (unwinding FOPs with op_errno. Added
gf_worm prefix to functions in worm-helper.c and made the functions static in
worm.c.) posted (#1) for review on master by Karthik U S (ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-12 03:17:28 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#2) for review on master by Karthik U S
(ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-25 06:55:21 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#3) for review on master by Niels de
Vos (ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-26 04:28:10 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#4) for review on master by Karthik U S
(ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-26 14:53:20 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#5) for review on master by Karthik U S
(ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-27 08:16:33 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#6) for review on master by Karthik U S
(ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-30 09:29:20 EDT ---

REVIEW: http://review.gluster.org/14222 (features/worm: updating function names
& unwinding FOPs with op_errno) posted (#7) for review on master by Karthik U S
(ksubrahm at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-31 11:56:00 EDT ---

COMMIT: http://review.gluster.org/14222 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 03880f81dad9fd2a3a07c56a3cfbb994d44819b7
Author: karthik-us <ksubrahm at redhat.com>
Date:   Thu May 5 12:42:35 2016 +0530

    features/worm: updating function names & unwinding FOPs with op_errno

    - Added gf_worm prefix to some of the functions in worm-helper files so
that
      they do not clash with other functions
    - Made the functions in worm.c static
    - Unwinding the FOPs with op_errno instead of using different unwind
statements
    - Removed the multiple goto labels (wind & unwind)

    Change-Id: I3a2f114061aae4b422df54e91c4b3f702af5d0b0
    BUG: 1333263
    Signed-off-by: karthik-us <ksubrahm at redhat.com>
    Reviewed-on: http://review.gluster.org/14222
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Joseph Fernandes
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.