[Bugs] [Bug 1361665] New: Memory leak observed with upcall polling

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 29 16:47:30 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1361665

            Bug ID: 1361665
           Summary: Memory leak observed with upcall polling
           Product: GlusterFS
           Version: 3.8.1
         Component: upcall
          Keywords: Triaged
          Severity: high
          Assignee: skoduri at redhat.com
          Reporter: skoduri at redhat.com
                CC: bugs at gluster.org
        Depends On: 1358608
            Blocks: 1338068
            Status: POST
          Assignee: skoduri at redhat.com



+++ This bug was initially created as a clone of Bug #1358608 +++

Description of problem:

There is memory leak observed when there are large number of upcall
notifications generated. Ideally after polling them, all the upcall events
generated should be cleaned up. But that wasn't the case. There were few upcall
events not cleaned up and resulted in memory leak.

The issue is that during polling (currently), upcall entries are not removed
under mutex lock. This resulted in the list corruption leaving few entries from
being removed.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-07-21 02:54:30 EDT ---

REVIEW: http://review.gluster.org/14972 (glfs/upcall: entries should be removed
under mutex lock) posted (#1) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-21 03:06:22 EDT ---

REVIEW: http://review.gluster.org/14972 (glfs/upcall: entries should be removed
under mutex lock) posted (#2) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-22 05:08:58 EDT ---

REVIEW: http://review.gluster.org/14984 (gfapi/upcall: Fix a ref leak) posted
(#1) for review on master by soumya k (skoduri at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-22 11:13:33 EDT ---

COMMIT: http://review.gluster.org/14972 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 89dee8b46e126bc1d7541da90fa60844aa83451e
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jul 21 12:14:27 2016 +0530

    glfs/upcall: entries should be removed under mutex lock

    During poll, upcall entries should be removed from the
    upcall_list only under upcall_list_mutex lock. Otherwise
    it could result in the list corruption if there are entries
    being added during poll resulting in memory leak.

    Also addressed a probable leak during any failures with upcall
    entry addition.

    Change-Id: I468183f961eb6faed9a0a1bcb783705f711641fc
    BUG: 1358608
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/14972
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

--- Additional comment from Vijay Bellur on 2016-07-24 05:55:32 EDT ---

COMMIT: http://review.gluster.org/14984 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit bb48eb46910085928efbd7fb491c5b2db25bba98
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Fri Jul 22 13:15:58 2016 +0530

    gfapi/upcall: Fix a ref leak

    inode_find (used to create the handle) takes a reference
    of the inode. This needs to be un'refernced to avoid leak.

    Change-Id: I22f03577a8f1d9608cfc62d57202cfc4c2ba12b3
    BUG: 1358608
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/14984
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1338068
[Bug 1338068] OOM kill of ganesha process while creation and removal of
files.
https://bugzilla.redhat.com/show_bug.cgi?id=1358608
[Bug 1358608] Memory leak observed with upcall polling
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list