[Bugs] [Bug 1360573] New: Fix spurious failures in split-brain-favorite-child-policy.t

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1360573

            Bug ID: 1360573
           Summary: Fix spurious failures in
                    split-brain-favorite-child-policy.t
           Product: GlusterFS
           Version: 3.8.1
         Component: tests
          Keywords: Triaged
          Severity: low
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: pkarampu at redhat.com
                CC: bugs at gluster.org
        Depends On: 1358976



+++ This bug was initially created as a clone of Bug #1358976 +++

Description of problem:
    Problem:
    It is not guranteed that the self-heal daemon would apply the new option
    as soon as volume set is executed because all the command gurantees is that
    the process is notified of the change in volfile. Shd still needs to fetch
    volfile and reconfigure. If the next volume heal command comes even before
    the reconfigure happens, then the heal won't happen.

    Fix:
    Restart shd to make sure it has the option loaded with new value.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-07-21 22:24:32 EDT ---

REVIEW: http://review.gluster.org/14978 (tests: Fix spurious failures with
split-brain-favorite-child-policy.t) posted (#1) for review on master by
Pranith Kumar Karampuri (pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-22 17:32:46 EDT ---

COMMIT: http://review.gluster.org/14978 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit b1559c2d1cfcff76df5870563a84cc22c752cc58
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Fri Jul 22 07:48:27 2016 +0530

    tests: Fix spurious failures with split-brain-favorite-child-policy.t

    Problem:
    It is not guranteed that the self-heal daemon would apply the new option
    as soon as volume set is executed because all the command gurantees is that
    the process is notified of the change in volfile. Shd still needs to fetch
    volfile and reconfigure. If the next volume heal command comes even before
    the reconfigure happens, then the heal won't happen.

    Fix:
    Restart shd to make sure it has the option loaded with new value.

    BUG: 1358976
    Change-Id: I3ed30ebbec17bd06caa632e79e9412564f431b19
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/14978
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    Tested-by: Jeff Darcy <jdarcy at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1358976
[Bug 1358976] Fix spurious failures in split-brain-favorite-child-policy.t
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.