[Bugs] [Bug 1211863] RFE: Support in md-cache to use upcall notifications to invalidate its cache

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 21 18:06:03 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1211863



--- Comment #58 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14971 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 370197f6e8413c0c4c13571f1c5b613bfa1e50d5
Author: Niels de Vos <ndevos at redhat.com>
Date:   Thu Jul 21 08:12:04 2016 +0200

    md-cache: fix indention to silence Coverity

    Coverity complains about the incorrect indention:

        *** CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
        ...
        2566                     if (conf->mdc_invalidation)
        2567                             ret = mdc_invalidate (this, data);
        >>>     CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
        >>>     This 'if'  statement is indented to column 25, as if it were
nested within the preceding parent statement, but it is not.
        2568                             if (default_notify (this, event, data)
!= 0)
        2569                                   ret = -1;
        2570                     break;
        ...

    Even when md-cache does not have cache-invalidation on, we need to pass
    the upcall to the next xlator.

    Change-Id: I6d2a174eb54e3df270920aae9673b5010c235f25
    CID: 1357867
    BUG: 1211863
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14971
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    Reviewed-by: Poornima G <pgurusid at redhat.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IwfH2tWZcA&a=cc_unsubscribe


More information about the Bugs mailing list