[Bugs] [Bug 1357766] New: Wrong XML output for Volume Options

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1357766

            Bug ID: 1357766
           Summary: Wrong XML output for Volume Options
           Product: GlusterFS
           Version: 3.7.13
         Component: cli
          Keywords: Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: bugs at gluster.org, hgowtham at redhat.com
        Depends On: 1302277



+++ This bug was initially created as a clone of Bug #1302277 +++

Description of problem:
gluster volume get <VOLNAME> all --xml returns wrong XML format

Version-Release number of selected component (if applicable):
Mainline

How reproducible:
Always

Steps to Reproduce:
1. Run gluster volume get <VOLNAME> all --xml

Actual results:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr/>
  <volGetopts>
    <count>258</count>
    <Option>cluster.lookup-unhashed</Option>
    <Value>on</Value>
    <Option>cluster.lookup-optimize</Option>
    <Value>off</Value>
    <Option>cluster.min-free-disk</Option>
    <Value>10%</Value>
    <Option>cluster.min-free-inodes</Option>
    <Value>5%</Value>


Expected results:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr/>
  <volGetopts>
    <count>258</count>
    <volGetopt>
        <Option>cluster.lookup-unhashed</Option>
        <Value>on</Value>
    </volGetopt>
    <volGetopt>
        <Option>cluster.lookup-optimize</Option>
        <Value>off</Value>
    </volGetopt>
    <volGetopt>
        <Option>cluster.min-free-disk</Option>
        <Value>10%</Value>
    </volGetopt>
    <volGetopt>
        <Option>cluster.min-free-inodes</Option>
        <Value>5%</Value>
    </volGetopt>


Additional info:

--- Additional comment from Vijay Bellur on 2016-07-15 09:28:14 EDT ---

REVIEW: http://review.gluster.org/14931 (cli/xml: Fix wrong XML format in
volume get command) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-16 13:54:17 EDT ---

REVIEW: http://review.gluster.org/14931 (cli/xml: Fix wrong XML format in
volume get command) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Vijay Bellur on 2016-07-18 08:00:25 EDT ---

COMMIT: http://review.gluster.org/14931 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit bc0b106f0ae8ecd336c7689917e46bc2685603c8
Author: Aravinda VK <avishwan at redhat.com>
Date:   Fri Jul 15 18:49:32 2016 +0530

    cli/xml: Fix wrong XML format in volume get command

    Without this Patch,
    <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
    <cliOutput>
      <opRet>0</opRet>
      <opErrno>0</opErrno>
      <opErrstr/>
      <volGetopts>
        <count>258</count>
        <Option>cluster.lookup-unhashed</Option>
        <Value>on</Value>
        <Option>cluster.lookup-optimize</Option>
        <Value>off</Value>
        <Option>cluster.min-free-disk</Option>
        <Value>10%</Value>
        <Option>cluster.min-free-inodes</Option>
        <Value>5%</Value>...

    With this patch,
    <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
    <cliOutput>
      <opRet>0</opRet>
      <opErrno>0</opErrno>
      <opErrstr/>
      <volGetopts>
        <count>258</count>
        <Opt>
            <Option>cluster.lookup-unhashed</Option>
            <Value>on</Value>
        </Opt>
        <Opt>
            <Option>cluster.lookup-optimize</Option>
            <Value>off</Value>
        </Opt>
        <Opt>
            <Option>cluster.min-free-disk</Option>
            <Value>10%</Value>
        </Opt>
        <Opt>
            <Option>cluster.min-free-inodes</Option>
            <Value>5%</Value>
        </Opt>...

    BUG: 1302277
    Change-Id: I6c5a040f659f2244ddcd47c57882b4f300cbe52f
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/14931
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302277
[Bug 1302277] Wrong XML output for Volume Options
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.