[Bugs] [Bug 1198849] Minor improvements and cleanup for the build system

bugzilla at redhat.com bugzilla at redhat.com
Sun Jul 17 13:37:01 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1198849



--- Comment #81 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14934 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 1b228d3d489cada1c3c9f5fdbb882e7dbc25a091
Author: Niels de Vos <ndevos at redhat.com>
Date:   Sat Jul 16 16:36:22 2016 +0200

    build: fix sprintf format for uint64_t in gf_worm_serialize_state()

    When building on 32-bit architectures, the following warning gets
    reported:

        worm-helper.c: In function 'gf_worm_serialize_state':
        worm-helper.c:219: warning: format '%ld' expects type 'long int', but
argument 4 has type 'uint64_t'
        worm-helper.c:219: warning: format '%ld' expects type 'long int', but
argument 5 has type 'uint64_t'

    The format string "%ld" depend on the architecture. If the type is very
    specific (here unint64_t), the dynamicness of "%ld" is not correct.
    There are macros for these fixed types in <inttypes.h> and even some
    more in "logging.h" from libglusterfs.

    BUG: 1198849
    Change-Id: I63eeb9c8e4d7b292ce0c9333938ca365db0823fc
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14934
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t5u7ACfN4S&a=cc_unsubscribe


More information about the Bugs mailing list