[Bugs] [Bug 1357421] New: Fail smoke tests if cherry-picked bugs contain the old git-tags

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1357421

            Bug ID: 1357421
           Summary: Fail smoke tests if cherry-picked bugs contain the old
                    git-tags
           Product: GlusterFS
           Version: mainline
         Component: tests
          Keywords: Triaged
          Assignee: nigelb at redhat.com
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org



Description of problem:
The commit message of patches should not have incorrect tags. This is common to
see when backports are done through the Gerrit webui. Many seem to ignore the
http://gluster.readthedocs.io/en/latest/Developer-guide/Backport-Guidelines/
where it is clearly mentioned what changes to the commit message are required.

Backports may rely on other changes, or may have been modified in order to
match the older version of the code. Keeping the git-tags from the backported
patch is suggested, but indention is required to make the distinction between
the old and the new (inserted by Gerrit on merging) onced.

Version-Release number of selected component (if applicable):
all

How reproducible:
Backport a change without taking the Backport Guidelines into account.


Actual results:
For example http://review.gluster.org/#/c/13863/1

Expected results:
http://review.gluster.org/#/c/13863/2

Additional info:
A new Jenkins job that is part of the smoke test would do. The following
git-tags in the commit message should be prohibited:

Reviewed-on:
Smoke:
CentOS-regression:
NetBSD-regression:

A basic script that fails when the commit message contains any of these:

MATCHES=$(git log -1 --format=email | grep -c \
    -e '^Reviewed-on:' \
    -e '^Smoke:' \
    -e '^CentOS-regression:' \
    -e '^NetBSD-regression:')

exit ${MATCHES}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rADiDpgLH2&a=cc_unsubscribe