[Bugs] [Bug 1353429] New: client ID should logged when SSL connection fails

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1353429

            Bug ID: 1353429
           Summary: client ID should logged when SSL connection fails
           Product: GlusterFS
           Version: 3.8.0
         Component: protocol
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: amukherj at redhat.com, annair at redhat.com,
                    bugs at gluster.org, rabhat at redhat.com,
                    rhs-bugs at redhat.com
        Depends On: 1333885, 1333912
            Blocks: 1351878, 1351933



+++ This bug was initially created as a clone of Bug #1333912 +++

+++ This bug was initially created as a clone of Bug #1333885 +++

Description of problem:

when a client tries to connect using SSl, and the connection fails, the client
identifier (either IP address or the hostname) should be logged to help
identify which client was attempting the connect.

[2016-04-04 13:06:57.982869] E [socket.c:352:ssl_setup_connection]
0-socket.management: SSL connect error
[2016-04-04 13:06:57.983084] E [socket.c:206:ssl_dump_error_stack]
0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong
version number
[2016-04-04 13:06:57.983276] E [socket.c:2388:socket_poller]
0-socket.management: server setup failed
[2016-04-04 13:07:00.987987] E [socket.c:352:ssl_setup_connection]
0-socket.management: SSL connect error
[2016-04-04 13:07:00.988203] E [socket.c:206:ssl_dump_error_stack]
0-socket.management:   error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong
version number

In the above logs ssl_setup_connection does not log the client identifier.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Raghavendra Bhat on 2016-05-06 12:13:51 EDT ---



--- Additional comment from Raghavendra Bhat on 2016-05-06 12:14:17 EDT ---



--- Additional comment from Vijay Bellur on 2016-05-06 12:16:03 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in
ssl connect) posted (#2) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-29 13:04:08 EDT ---

REVIEW: http://review.gluster.org/14242 (socket: log the client identifier in
ssl connect) posted (#3) for review on master by Vijay Bellur
(vbellur at redhat.com)

--- Additional comment from Vijay Bellur on 2016-06-30 18:24:23 EDT ---

COMMIT: http://review.gluster.org/14242 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit d308fb5e152d8c908bf4f5da81f553fbe3d0400a
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Fri May 6 10:03:53 2016 -0400

    socket: log the client identifier in ssl connect

    Change-Id: I4b463ecafb66de16cbe7ed23fae800bb1204f829
    BUG: 1333912
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/14242
    Tested-by: Vijay Bellur <vbellur at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1333885
[Bug 1333885] client ID should logged when SSL connection fails
https://bugzilla.redhat.com/show_bug.cgi?id=1333912
[Bug 1333912] client ID should logged when SSL connection fails
https://bugzilla.redhat.com/show_bug.cgi?id=1351878
[Bug 1351878] client ID should logged when SSL connection fails
https://bugzilla.redhat.com/show_bug.cgi?id=1351933
[Bug 1351933] client ID should logged when SSL connection fails
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.