[Bugs] [Bug 1352875] New: Check for return code when glusterd is started in upgrade scenario

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1352875

            Bug ID: 1352875
           Summary: Check for return code when glusterd is started in
                    upgrade scenario
           Product: GlusterFS
           Version: mainline
         Component: build
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: atalur at redhat.com
                CC: bugs at gluster.org



Description of problem:
During upgrade cases, when glusterd is started as part of upgrade (check
glusterfs.spec.in), its return code is not checked.

Code snippet :
"else
    glusterd --xlator-option *.upgrade=on -N  <--- return code not checked

    #Cleaning leftover glusterd socket file which is created by glusterd in
    #rpm_script_t context.
    rm -rf /var/run/glusterd.socket
"

So when an error is hit, it is not communicated to the user. Even though
glusterd logs errors in the glusterd logfile, on the cli side no failure is
seen. This is misleading. Some genuine failures go unnoticed.

A problem was seen in upgrade from 3.6.x to 3.7.9 where glusterd start on
upgrade failed. As a consequence new volfiles were not generated and index
xlator didn't get the options that it was supposed to be provided with. Leading
to incorrect functionality of index translator and AFR selfheal.

So it would be better if we at least print a warning on the command line
interface during such failures.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Install glusterfs 3.6.x
2. create a replicate volume
3. kill all gluster processes
4. update glusterfs to 3.7.9 using yum update


Actual results:
A failure is seen in the 4th step as per glusterd logs but not on cli.

Expected results:
If there is a failure in bringing up glusterd, it should be indicated on the
cli too.

Additional info:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.