[Bugs] [Bug 1352281] Issues reported by Coverity static analysis tool

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1352281



--- Comment #2 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14850 committed in release-3.8 by Atin
Mukherjee (amukherj at redhat.com) 
------
commit 021813ca53762f09cb9f43d740a6aaab5659aa51
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Tue Jun 28 15:32:17 2016 +0530

    glusterd/cli: coverity fixes

    Backport of http://review.gluster.org/#/c/14818/

    A downstream coverity run has revealed few of the following coverity
defects.
    Since the downstream code is a clone of a specific upstream branch the
defects
    hold true for the upstream as well.

    Defect type: NEGATIVE_RETURNS
    xlators/mgmt/glusterd/src/glusterd-rpc-ops.c:641: negative_returns:
"op_errno"
    is passed to a parameter that cannot be negative.

    Defect type: BUFFER_SIZE_WARNING
    xlators/mgmt/glusterd/src/glusterd-volume-ops.c:2124: buffer_size_warning:
    Calling strncpy with a maximum size argument of 261 bytes on destination
array
    "volinfo->volname" of size 261 bytes might leave the destination string
    unterminated.

    Defect type: BUFFER_SIZE_WARNING
    xlators/mgmt/glusterd/src/glusterd-volgen.c:4888: buffer_size_warning:
Calling
    strncpy with a maximum size argument of 261 bytes on destination array
    "volinfo->volname" of size 261 bytes might leave the destination string
    unterminated.

    Defect type: STRING_OVERFLOW
    xlators/mgmt/glusterd/src/glusterd-volgen.c:3449: string_overflow: You
might
    overrun the 256 byte destination string "tmp_volname" by writing 261 bytes
from
    "volinfo->volname".

    Defect type: BUFFER_SIZE_WARNING
    xlators/mgmt/glusterd/src/glusterd-utils.c:3392: buffer_size_warning:
Calling
    strncpy with a maximum size argument of 261 bytes on destination array
    "new_volinfo->volname" of size 261 bytes might leave the destination string
    unterminated.

    Defect type: NO_EFFECT
    xlators/mgmt/glusterd/src/glusterd-utils.c:7359: remediation: Was
    "rebal->rebalance_id" formerly declared as a pointer?

    Defect type: USE_AFTER_FREE
    xlators/mgmt/glusterd/src/glusterd-utils.c:7115: pass_freed_arg: Passing
freed
    pointer "volinfo" as an argument to "glusterd_friend_contains_vol_bricks".

    Defect type: DEADCODE
    cli/src/cli-cmd-parser.c:1767: dead_error_begin: Execution cannot reach
this
    statement: "ret = -1;".

    Change-Id: Ie941bdf31923e2f39618dd94bfae16fdb3ad65f1
    BUG: 1352281
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/14818
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
    Reviewed-on: http://review.gluster.org/14850
    Reviewed-by: Prashanth Pai <ppai at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.