[Bugs] [Bug 1408111] New: [GANESHA] Deleting a node from ganesha cluster deletes the volume entry from /etc/ ganesha/ganesha.conf file
bugzilla at redhat.com
bugzilla at redhat.com
Thu Dec 22 07:21:28 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1408111
Bug ID: 1408111
Summary: [GANESHA] Deleting a node from ganesha cluster deletes
the volume entry from /etc/ganesha/ganesha.conf file
Product: GlusterFS
Version: 3.9
Component: common-ha
Keywords: EasyFix, Triaged
Priority: urgent
Assignee: jthottan at redhat.com
Reporter: jthottan at redhat.com
CC: bugs at gluster.org, msaini at redhat.com,
rhs-bugs at redhat.com, skoduri at redhat.com,
storage-qa-internal at redhat.com
Depends On: 1406025, 1406249
+++ This bug was initially created as a clone of Bug #1406249 +++
+++ This bug was initially created as a clone of Bug #1406025 +++
Description of problem:
When the node is deleted from existing ganesha cluster,volume entry of the
exported volume gets deleted from /etc/ganesha/ganesha.conf file.
As a result the existing node reflects the stale entry of the volume in
showmount -e localhost
Version-Release number of selected component (if applicable):
# rpm -qa | grep ganesha
nfs-ganesha-2.4.1-3.el7rhgs.x86_64
nfs-ganesha-gluster-2.4.1-3.el7rhgs.x86_64
glusterfs-ganesha-3.8.4-9.el7rhgs.x86_64
How reproducible:
Consistently
Steps to Reproduce:
1.Create 6 node ganesha cluster on 8 node gluster.Enable ganesha on it
2.Delete 1 node from existing ganesha cluster
/usr/libexec/ganesha/ganesha-ha.sh --delete
/var/run/gluster/shared_storage/nfs-ganesha/ dhcp46-232.lab.eng.blr.redhat.com
3.Check /etc/ganesha/ganesha.conf file.
Actual results:
Check /etc/ganesha/ganesha.conf file.Volume which was previously exported gets
deleted from this file.
showmount -e localhost reflects stale entry of previously exported volume
In this case if the node is deleted and again added,previously exported volume
(before node delete) is not exported on the node which is added.
Expected results:
It should not modify the /etc/ganesha/ganesha.conf file.
Volume should be exported on the newly added node
Additional info:
--- Additional comment from Soumya Koduri on 2016-12-19 11:54:27 EST ---
create_ganesha_conf_file()
{
if [ $1 == "yes" ];
then
if [ -e $GANESHA_CONF ];
then
rm -rf $GANESHA_CONF
fi
# The symlink /etc/ganesha/ganesha.conf need to be
# created using ganesha conf file mentioned in the
# shared storage. Every node will only have this
# link and actual file will stored in shared storage,
# so that ganesha conf editing of ganesha conf will
# be easy as well as it become more consistent.
ln -s $HA_CONFDIR/ganesha.conf $GANESHA_CONF
else
# Restoring previous file
rm -rf $GANESHA_CONF
sed -r -i -e '/^%include[[:space:]]+".+\.conf"$/d'
$HA_CONFDIR/ganesha.conf
^^^^ This line (which could have removed $VOL.conf in ganesha.conf file) is not
necessary IMO. Jiffin would be best to comment
--- Additional comment from Jiffin on 2016-12-19 13:16:25 EST ---
(In reply to Soumya Koduri from comment #2)
>
> create_ganesha_conf_file()
>
> {
> if [ $1 == "yes" ];
>
> then
> if [ -e $GANESHA_CONF ];
>
> then
> rm -rf $GANESHA_CONF
>
> fi
> # The symlink /etc/ganesha/ganesha.conf need to be
>
> # created using ganesha conf file mentioned in the
>
> # shared storage. Every node will only have this
> # link and actual file will stored in shared storage,
>
> # so that ganesha conf editing of ganesha conf will
>
> # be easy as well as it become more consistent.
>
>
> ln -s $HA_CONFDIR/ganesha.conf $GANESHA_CONF
>
> else
> # Restoring previous file
> rm -rf $GANESHA_CONF
> sed -r -i -e '/^%include[[:space:]]+".+\.conf"$/d'
> $HA_CONFDIR/ganesha.conf
>
>
> ^^^^ This line (which could have removed $VOL.conf in ganesha.conf file) is
> not necessary IMO. Jiffin would be best to comment
Yes above mentioned is absolutely correct. Based on that I have given
workaround in Manisha's setup. But didn't work out as expected. Tomorrow I will
check again
--- Additional comment from Worker Ant on 2016-12-20 00:27:31 EST ---
REVIEW: http://review.gluster.org/16209 (ganesha/scripts : Prevent removal of
entries in ganesha.conf during deletion of a node) posted (#1) for review on
master by jiffin tony Thottan (jthottan at redhat.com)
--- Additional comment from Worker Ant on 2016-12-21 07:51:27 EST ---
COMMIT: http://review.gluster.org/16209 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com)
------
commit 8b42e1b5688f8600086ecc0e33ac4abf5e7c2772
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date: Tue Dec 20 10:42:31 2016 +0530
ganesha/scripts : Prevent removal of entries in ganesha.conf during
deletion of a node
Change-Id: Ia6c653eeb9bef7ff4107757f845218c2316db2e4
BUG: 1406249
Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
Reviewed-on: http://review.gluster.org/16209
Smoke: Gluster Build System <jenkins at build.gluster.org>
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
Reviewed-by: soumya k <skoduri at redhat.com>
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1406025
[Bug 1406025] [GANESHA] Deleting a node from ganesha cluster deletes the
volume entry from /etc/ganesha/ganesha.conf file
https://bugzilla.redhat.com/show_bug.cgi?id=1406249
[Bug 1406249] [GANESHA] Deleting a node from ganesha cluster deletes the
volume entry from /etc/ganesha/ganesha.conf file
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Zp1ecdZl3&a=cc_unsubscribe
More information about the Bugs
mailing list