[Bugs] [Bug 1405886] New: Fix potential leaks in INODELK cbk in protocol/client

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1405886

            Bug ID: 1405886
           Summary: Fix potential leaks in INODELK cbk in protocol/client
           Product: GlusterFS
           Version: 3.8
         Component: core
          Keywords: Triaged
          Assignee: kdhananj at redhat.com
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org
        Depends On: 1405885



+++ This bug was initially created as a clone of Bug #1405885 +++

Description of problem:

There is a potential leak in protocol/client's INODELK callback:

<code>
 31
 30         GF_PROTOCOL_DICT_UNSERIALIZE (this, xdata, (rsp.xdata.xdata_val),
 29                                       (rsp.xdata.xdata_len), ret,
 28                                       rsp.op_errno, out);
 27
 26         ret = client_post_inodelk (this, &rsp, &xdata);
 25         if (ret < 0)
 24                 goto out;
 23 out:
</code>

The dict xdata is unserialized twice - once at line 30 and once inside
client_post_inodelk function called at line 26. This is a memory leak. We're
safe as of today because none of the xlators on the client stack that invoke
inodelk fop (like AFR, DHT etc) pass xdata while winding it.



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-12-18 23:16:03 EST ---

REVIEW: http://review.gluster.org/16186 (protocol/client: Fix potential
mem-leaks) posted (#1) for review on release-3.9 by Krutika Dhananjay
(kdhananj at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1405885
[Bug 1405885] Fix potential leaks in INODELK cbk in protocol/client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rpobHkXZyd&a=cc_unsubscribe