[Bugs] [Bug 1388461] [Eventing]: BRICK_DISCONNECTED events seen when a tier volume is stopped

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1388461



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15722 committed in release-3.9 by Atin
Mukherjee (amukherj at redhat.com) 
------
commit 2b5f080ba39ff0a7e2b5c3bc554f5680cf925858
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Fri Oct 21 18:27:45 2016 +0530

    glusterd: use GF_BRICK_STOPPING as intermediate brickinfo->status state

    On a volume stop trigger glusterd issues a brick-op to terminate the brick
    process during brick-op phase , however in the commit-op glusterd once
again
    tries to kill the same process if it exists and then mark the
brickinfo->status
    flag to GF_BRICK_STOPPED. In the former case, if brick is successfully
killed
    there is a possibility that GlusterD will receive RPC_CLNT_DISCONNECT from
the
    said brick process before even the commit op phase is executed and hence by
that
    time brickinfo->status will still be set to GF_BRICK_STARTED.

    BRICK_DISCONNECT event should be only sent if a brick has been killed and
not
    through a volume stop/remove brick trigger, however due to this trace, this
    event is also sent out on a volume stop.

    Fix is to introduce an intermediate state GF_BRICK_STOPPING which can be
used to
    mark the brick status at brick op phase of volume stop/remove brick to
avoid
    sending spurious BRICK_DISCONNECT events on a volume stop trigger.

    >Reviewed-on: http://review.gluster.org/15699
    >Smoke: Gluster Build System <jenkins at build.gluster.org>
    >NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    >CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    >Reviewed-by: Kaushal M <kaushal at redhat.com>

    Change-Id: Ieed4450e1c988715e0f9958be44faa6b14be81e1
    BUG: 1388461
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/15722
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oOaI56PEVn&a=cc_unsubscribe