[Bugs] [Bug 1387241] Pass proper permission to acl_permit() in posix_acl_open()

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 14 13:01:10 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1387241



--- Comment #4 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/15688 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit e81fd0b85c8dd3f521e54e32b7da2f99a513f2f2
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Thu Nov 17 18:22:39 2016 +0530

    access_control : address O_TRUNC and O_APPEND flag properly in
posix_acl_open

    In posix_acl_open, in switch value passed is (flag & O_ACCMODE). The value
for
    O_ACCMODE is 0003, so the result will always be less than or equal to 3.
    But value for O_TRUNC is 01000 and O_APPEND is 02000, so it is not right to
    check it in switch case

    Change-Id: Ia17db80a6a5f681c35e08e062d384f33ef7e0354
    BUG: 1387241
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Reviewed-on: http://review.gluster.org/15688
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o6XdA7jlbu&a=cc_unsubscribe


More information about the Bugs mailing list