[Bugs] [Bug 1402730] self-heal not happening, as self-heal info lists the same pending shards to be healed

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 12 16:38:52 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1402730



--- Comment #4 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16075 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 2b76520ca3e41cbac8f9318dce87e0b8d670c0ee
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Thu Dec 8 22:49:48 2016 +0530

    cluster/afr: Fix per-txn optimistic changelog initialisation

    Incorrect initialisation of local->optimistic_change_log was leading
    to skipped pre-op and post-op even when a brick didn't participate in
    the txn because it was down.
    The result - missing granular name index resulting in some entries
    never getting healed.

    FIX:
    Initialise local->optimistic_change_log just before pre-op.

    Also fixed granular entry heal to create the granular name index in
    pre-op as opposed to post-op. This is to prevent loss of granular
    information when during an entry txn, the good (src) brick goes
    offline before the post-op is done. This would cause self-heal to
    do conservative merge (since dirty xattr is the only information
    available), which when granular-entry-heal is enabled, expects
    granular indices, the lack of which can lead to loss of data in
    the worst case.

    Change-Id: Ia3ad716d6fb1821555f02180e86e8711a79f958d
    BUG: 1402730
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/16075
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T5HQvvCkvc&a=cc_unsubscribe


More information about the Bugs mailing list