[Bugs] [Bug 1403187] Files remain unhealed forever if shd is disabled and re-enabled while healing is in progress.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1403187



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: http://review.gluster.org/16095 committed in release-3.9 by Pranith
Kumar Karampuri (pkarampu at redhat.com) 
------
commit 9566a22f86ee223c792a9b25d1ccb741474fb973
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri Dec 9 09:50:43 2016 +0530

    syncop: fix conditional wait bug in parallel dir scan

    Problem:
    The issue as seen by the user is detailed in the BZ but what is
    happening is if the no. of items in the wait queue == max-qlen,
    syncop_mt_dir_scan() does a pthread_cond_wait until the launched
    synctask workers dequeue the queue. But if for some reason the worker
    fails, the queue is never emptied due to which further invocations of
    syncop_mt_dir_scan() are blocked forever.

    Fix: Made some changes to _dir_scan_job_fn

    - If a worker encounters error while processing an entry, notify the
      readdir loop in syncop_mt_dir_scan() of the error but continue to process
      other entries in the queue, decrementing the qlen as and when we dequeue
      elements, and ending only when the queue is empty.

    - If the readdir loop in syncop_mt_dir_scan() gets an error form the
      worker, stop the readdir+queueing of further entries.


    > Reviewed-on: http://review.gluster.org/16073
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

    (cherry picked from commit 2d012c4558046afd6adb3992ff88f937c5f835e4)
    Change-Id: I39ce073e01a68c7ff18a0e9227389245a6f75b88
    BUG: 1403187
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/16095
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jBkM5mcctf&a=cc_unsubscribe