[Bugs] [Bug 1402212] New: Fix compound fops memory leaks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1402212

            Bug ID: 1402212
           Summary: Fix compound fops memory leaks
           Product: GlusterFS
           Version: 3.9
         Component: replicate
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org, pkarampu at redhat.com,
                    ravishankar at redhat.com
        Depends On: 1401218
            Blocks: 1401380



+++ This bug was initially created as a clone of Bug #1401218 +++

Description of problem:

Nag Pavan Chilakam has reported high consumption of memory with compound fops.
This bug is to track that bug.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-12-03 10:23:19 EST ---

REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in
COMPOUND fop cbk) posted (#1) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Worker Ant on 2016-12-03 12:05:02 EST ---

REVIEW: http://review.gluster.org/16020 (afr, client: More mem-leak fixes in
COMPOUND fop cbk) posted (#2) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Worker Ant on 2016-12-04 20:28:44 EST ---

COMMIT: http://review.gluster.org/16020 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit c89cb610f51e7a5df5c4b7e9378a7ac8ac513e46
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Sat Dec 3 09:09:15 2016 +0530

    afr, client: More mem-leak fixes in COMPOUND fop cbk

    Bugs found and fixed:
    1. Use correct subvolume index in pre-op-writev compound cbk
    2. Prevent use-after-free of local->compound_args members in
       compound fops cbk in protocol/client
    3. Fix xdata and xattr leaks in client_process_response
    4. Fix possible leak of xdata in client_pre_writev() in
       test mode.
    5. Free req->compound_req_array.compound_req_array_val as well
       after freeing its members
    6. Free tmp_rsp->flock.lk_owner.lk_owner_val in LK fop.

    Change-Id: I15b646d7d4e0e5cd4ea3d2d6452c815cf2eaf68f
    BUG: 1401218
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/16020
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>

--- Additional comment from Ravishankar N on 2016-12-05 10:47:20 EST ---

Sending one more fix.

--- Additional comment from Worker Ant on 2016-12-05 10:47:36 EST ---

REVIEW: http://review.gluster.org/16029 (afr: fix bug in passing child index in
afr_inode_write_fill) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Worker Ant on 2016-12-06 07:12:04 EST ---

COMMIT: http://review.gluster.org/16029 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit ca13525a5de8db745878c4cdf89a45b76a9e62c6
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon Dec 5 21:14:57 2016 +0530

    afr: fix bug in passing child index in afr_inode_write_fill

    Change-Id: I7b70de317a5f15a3bf483ffe40b971143deddc11
    BUG: 1401218
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/16029
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401218
[Bug 1401218] Fix compound fops memory leaks
https://bugzilla.redhat.com/show_bug.cgi?id=1401380
[Bug 1401380] [Compound FOPs] : Memory leaks while doing deep directory
creation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.