[Bugs] [Bug 1401261] New: Delayed Events if any one Webhook is slow

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1401261

            Bug ID: 1401261
           Summary: Delayed Events if any one Webhook is slow
           Product: GlusterFS
           Version: 3.9
         Component: eventsapi
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: avishwan at redhat.com
        Depends On: 1357754
            Blocks: 1395613



+++ This bug was initially created as a clone of Bug #1357754 +++

Description of problem:
If Webhook takes more time to consume the events, it may affect the further
pushing of Events. Add configurable Timeout option while calling Webhook.

# Example, Set Timeout in seconds
gluster-eventsapi config-set webhook-timeout 30

--- Additional comment from Aravinda VK on 2016-11-16 04:50:13 EST ---

Also observed that, if one webhook is slow then future events gets delayed.
Webhooks should be called asynchronously to avoid delays.

--- Additional comment from Worker Ant on 2016-11-29 06:13:16 EST ---

REVIEW: http://review.gluster.org/15966 (eventsapi: Push Messages to Webhooks
in parallel) posted (#1) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Aravinda VK on 2016-11-29 06:16:38 EST ---

Separate threads maintained for each Webhook so that slow Webhook will not
affect the other webhooks. With this change we do not need configurable option
for Timeout.

--- Additional comment from Worker Ant on 2016-12-02 01:25:41 EST ---

REVIEW: http://review.gluster.org/15966 (eventsapi: Push Messages to Webhooks
in parallel) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-12-02 09:52:59 EST ---

COMMIT: http://review.gluster.org/15966 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 99458974b7d12bd12d78d4b9a19adfb62d771b5c
Author: Aravinda VK <avishwan at redhat.com>
Date:   Tue Nov 29 16:32:54 2016 +0530

    eventsapi: Push Messages to Webhooks in parallel

    With this patch, glustereventsd will maintain one thread per
    webhook. If a webhook is slow, then all the events to that worker
    will be delayed but it will not affect the other webhooks.

    Note: Webhook in transit may get missed if glustereventsd reloads due to
    new Webhook addition or due configuration changes.

    BUG: 1357754
    Change-Id: I2d11e01c7ac434355bc356ff75396252f51b339b
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/15966
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Prashanth Pai <ppai at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1357754
[Bug 1357754] Delayed Events if any one Webhook is slow
https://bugzilla.redhat.com/show_bug.cgi?id=1395613
[Bug 1395613] Delayed Events if any one Webhook is slow
-- 
You are receiving this mail because:
You are the assignee for the bug.