[Bugs] [Bug 1400923] New: Checkpoint completed event missing master node detail

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 2 10:19:58 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1400923

            Bug ID: 1400923
           Summary: Checkpoint completed event missing master node detail
           Product: GlusterFS
           Version: 3.9
         Component: geo-replication
          Severity: medium
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: amukherj at redhat.com, avishwan at redhat.com,
                    bugs at gluster.org, csaba at redhat.com,
                    rhinduja at redhat.com, rhs-bugs at redhat.com,
                    sabose at redhat.com, sasundar at redhat.com,
                    storage-qa-internal at redhat.com
        Depends On: 1388755, 1395660



+++ This bug was initially created as a clone of Bug #1395660 +++

+++ This bug was initially created as a clone of Bug #1388755 +++

Description of problem:

The message returned at checkpoint completion event is missing the master node
detail (contains only brick_path). This is insufficient data to parse and
update the info maintained in dependent applications like oVirt or other
scripts/

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
NA

--- Additional comment from Sahina Bose on 2016-10-26 02:08:47 EDT ---

Is it possible to return session_key in message?

--- Additional comment from Worker Ant on 2016-11-16 06:23:25 EST ---

REVIEW: http://review.gluster.org/15858 (geo-rep/eventsapi: Add Master node
information in Checkpoint Event) posted (#1) for review on master by Aravinda
VK (avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-11-30 06:53:21 EST ---

REVIEW: http://review.gluster.org/15858 (geo-rep/eventsapi: Add Master node
information in Geo-rep Events) posted (#2) for review on master by Aravinda VK
(avishwan at redhat.com)

--- Additional comment from Worker Ant on 2016-12-02 05:16:35 EST ---

COMMIT: http://review.gluster.org/15858 committed in master by Aravinda VK
(avishwan at redhat.com) 
------
commit 91e72a0f2e4e51ce20550946578a6d50cbb88e26
Author: Aravinda VK <avishwan at redhat.com>
Date:   Wed Nov 16 16:50:50 2016 +0530

    geo-rep/eventsapi: Add Master node information in Geo-rep Events

    Added Master node information to GEOREP_ACTIVE, GEOREP_PASSIVE,
GEOREP_FAULTY
    and GEOREP_CHECKPOINT_COMPLETED events.

    EVENT_GEOREP_ACTIVE(master_node and master_node_id are new fields)
    {
        "nodeid": NODEID,
        "ts": TIMESTAMP,
        "event": "GEOREP_ACTIVE",
        "message": {
            "master_volume": MASTER_VOLUME_NAME,
            "master_node": MASTER_NODE,
            "master_node_id": MASTER_NODE_ID,
            "slave_host": SLAVE_HOST,
            "slave_volume": SLAVE_VOLUME,
            "brick_path": BRICK_PATH
        }
    }

    EVENT_GEOREP_PASSIVE(master_node and master_node_id are new fields)
    {
        "nodeid": NODEID,
        "ts": TIMESTAMP,
        "event": "GEOREP_PASSIVE",
        "message": {
            "master_volume": MASTER_VOLUME_NAME,
            "master_node": MASTER_NODE,
            "master_node_id": MASTER_NODE_ID,
            "slave_host": SLAVE_HOST,
            "slave_volume": SLAVE_VOLUME,
            "brick_path": BRICK_PATH
        }
    }

    EVENT_GEOREP_FAULTY(master_node and master_node_id are new fields)
    {
        "nodeid": NODEID,
        "ts": TIMESTAMP,
        "event": "GEOREP_FAULTY",
        "message": {
            "master_volume": MASTER_VOLUME_NAME,
            "master_node": MASTER_NODE,
            "master_node_id": MASTER_NODE_ID,
            "current_slave_host": CURRENT_SLAVE_HOST,
            "slave_host": SLAVE_HOST,
            "slave_volume": SLAVE_VOLUME,
            "brick_path": BRICK_PATH
        }
    }

    EVENT_GEOREP_CHECKPOINT_COMPLETED(master_node and master_node_id are new
fields)
    {
        "nodeid": NODEID,
        "ts": TIMESTAMP,
        "event": "GEOREP_CHECKPOINT_COMPLETED",
        "message": {
            "master_volume": MASTER_VOLUME_NAME,
            "master_node": MASTER_NODE,
            "master_node_id": MASTER_NODE_ID,
            "slave_host": SLAVE_HOST,
            "slave_volume": SLAVE_VOLUME,
            "brick_path": BRICK_PATH,
            "checkpoint_time": CHECKPOINT_TIME,
            "checkpoint_completion_time": CHECKPOINT_COMPLETION_TIME
        }
    }

    BUG: 1395660
    Change-Id: Ic91af52fa248c8e982e93a06be861dfd69689f34
    Signed-off-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-on: http://review.gluster.org/15858
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kotresh HR <khiremat at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1388755
[Bug 1388755] Checkpoint completed event missing master node detail
https://bugzilla.redhat.com/show_bug.cgi?id=1395660
[Bug 1395660] Checkpoint completed event missing master node detail
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list