[Bugs] [Bug 1400802] New: glusterfs_ctx_defaults_init is re-initializing ctx-> locks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1400802

            Bug ID: 1400802
           Summary: glusterfs_ctx_defaults_init is re-initializing
                    ctx->locks
           Product: GlusterFS
           Version: 3.8
         Component: cli
          Assignee: bugs at gluster.org
          Reporter: rjoseph at redhat.com
                CC: bugs at gluster.org
        Depends On: 1397419



+++ This bug was initially created as a clone of Bug #1397419 +++

Description of problem:

In glusterfs_ctx_defaults_init both glusterfsd and cli is re-initializing
ctx->locks which can overwrite previous state.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-11-22 08:59:07 EST ---

REVIEW: http://review.gluster.org/15904 (cli: glusterfs_ctx_defaults_init
should not re-initialize ctx->locks) posted (#1) for review on master by Rajesh
Joseph (rjoseph at redhat.com)

--- Additional comment from Worker Ant on 2016-11-22 08:59:10 EST ---

REVIEW: http://review.gluster.org/15905 (glusterfsd:
glusterfs_ctx_defaults_init should not re-initialize ctx->locks) posted (#1)
for review on master by Rajesh Joseph (rjoseph at redhat.com)

--- Additional comment from Worker Ant on 2016-11-24 09:29:05 EST ---

COMMIT: http://review.gluster.org/15904 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 8df8a2308fcf5efda638f160428158127930d00f
Author: Rajesh Joseph <rjoseph at redhat.com>
Date:   Tue Nov 22 01:48:26 2016 +0530

    cli: glusterfs_ctx_defaults_init should not re-initialize ctx->locks

    glusterfs_ctx_new already initialize ctx->locks therefore the second
    initialization in glusterfs_ctx_defaults_init does not make sense.

    Change-Id: I8a44bed13af20e60e8bafb05360e88c0b237056c
    BUG: 1397419
    Signed-off-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-on: http://review.gluster.org/15904
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

--- Additional comment from Worker Ant on 2016-12-02 01:23:42 EST ---

COMMIT: http://review.gluster.org/15905 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 47e69455d3aede77960fd81a7cf3d6b4a869dbfa
Author: Rajesh Joseph <rjoseph at redhat.com>
Date:   Tue Nov 22 01:51:19 2016 +0530

    glusterfsd: glusterfs_ctx_defaults_init should not re-initialize ctx->locks

    glusterfs_ctx_new already initialize ctx->locks therefore the second
    initialization in glusterfs_ctx_defaults_init does not make sense.

    Change-Id: I6027cbd311da8e80585e0f0dcd6916e3bc8dd284
    BUG: 1397419
    Signed-off-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-on: http://review.gluster.org/15905
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Poornima G <pgurusid at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397419
[Bug 1397419] glusterfs_ctx_defaults_init is re-initializing ctx->locks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.