[Bugs] [Bug 1400635] New: build: add systemd dependency to glusterfs sub-package

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1400635

            Bug ID: 1400635
           Summary: build: add systemd dependency to glusterfs sub-package
           Product: GlusterFS
           Version: 3.9
         Component: build
          Assignee: bugs at gluster.org
          Reporter: mchangir at redhat.com
                CC: bugs at gluster.org
        Depends On: 1399031
            Blocks: 1377062



+++ This bug was initially created as a clone of Bug #1399031 +++

Description of problem:
glusterfs.spec.in refers to /bin/systemctl
This is not the path that systemctl is found in.
It is found at /usr/bin
Also, its not a good practice to refer to utilities with their absolute paths.

Additional info:
The absolute path will now be changed to %{_bindir}/systemctl

--- Additional comment from Milind Changire on 2016-11-28 01:17:23 EST ---

Correction:
systemctl will be referred to with just the base name and without any path
prefix.

--- Additional comment from Worker Ant on 2016-11-28 01:20:11 EST ---

REVIEW: http://review.gluster.org/15936 (build: remove absolute paths to
systemctl) posted (#1) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-28 04:16:30 EST ---

REVIEW: http://review.gluster.org/15936 (build: remove absolute paths to
systemctl) posted (#2) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-29 10:58:14 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
primary package) posted (#3) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-29 11:00:28 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
primary package) posted (#4) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-30 03:53:02 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
glusterfs sub-package) posted (#5) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-30 06:52:00 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
glusterfs sub-package) posted (#6) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-11-30 09:12:03 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
glusterfs sub-package) posted (#7) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-12-01 07:39:57 EST ---

REVIEW: http://review.gluster.org/15936 (build: add systemd dependency to the
glusterfs sub-package) posted (#8) for review on master by Milind Changire
(mchangir at redhat.com)

--- Additional comment from Worker Ant on 2016-12-01 09:56:49 EST ---

COMMIT: http://review.gluster.org/15936 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 6138f4a2fc835bc94aa66543f5aee4f92081f1c7
Author: Milind Changire <mchangir at redhat.com>
Date:   Wed Nov 30 19:38:03 2016 +0530

    build: add systemd dependency to the glusterfs sub-package

    Problem:
    /bin/systemctl is not available at install time of primary glusterfs
    package.

    Solution:
    Add %{?systemd_requires} to the glusterfs sub-package install time
    requirements.

    Replace all "Requires: systemd" and "Requires: systemd-units" with
    %{?systemd_requires}. %systemd_requires is defined in
    /usr/lib/rpm/macros.d/macros.systemd
    systemd-units is provided by systemd.
    Add BuildRequires: systemd for the definition of %systemd_requires
    as well.

    Change-Id: I980ece7d538ea177ca6b0e70c1c169e6f04c46d4
    BUG: 1399031
    Signed-off-by: Milind Changire <mchangir at redhat.com>
    Reviewed-on: http://review.gluster.org/15936
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra Talur <rtalur at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1377062
[Bug 1377062] /var/tmp/rpm-tmp.KPCugR: line 2: /bin/systemctl: No such file
or directory
https://bugzilla.redhat.com/show_bug.cgi?id=1399031
[Bug 1399031] build: add systemd dependency to glusterfs sub-package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.