[Bugs] [Bug 1400545] New: Dump volume specific options in get-state output in a more parseable manner

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1400545

            Bug ID: 1400545
           Summary: Dump volume specific options in get-state output in a
                    more parseable manner
           Product: GlusterFS
           Version: 3.9
         Component: glusterd
          Assignee: bugs at gluster.org
          Reporter: sbairagy at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org
        Depends On: 1399995



+++ This bug was initially created as a clone of Bug #1399995 +++

Description of problem:

Currently the get-state cli outputs the volume options in the following format:

Volume1.rebalance.skipped: 0                                                    
Volume1.rebalance.lookedup: 0                                                   
Volume1.rebalance.files: 0                                                      
Volume1.rebalance.data: 0Bytes                                                  
[Volume1.options]                                                               
features.barrier: on                                                            
transport.address-family: inet                                                  
performance.readdir-ahead: on                                                   
nfs.disable: on                                                                 

Volume2.name: tv2                                                         
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9                                
Volume2.type: Distribute

This above format is a valid ini file format syntactically, but is not very
easily parseable. The following format should be more easily parseable:

Volume1.rebalance.skipped: 0
Volume1.rebalance.lookedup: 0
Volume1.rebalance.files: 0
Volume1.rebalance.data: 0Bytes
Volume1.options.features.barrier: on
Volume1.options.transport.address-family: inet
Volume1.options.performance.readdir-ahead: on
Volume1.options.nfs.disable: on

Volume2.name: tv2
Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
Volume2.type: Distribute


Version-Release number of selected component (if applicable): mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2016-11-30 04:14:39 EST ---

REVIEW: http://review.gluster.org/15975 (glusterd, cli: Fix volume options
output format in get-state cli) posted (#1) for review on master by Samikshan
Bairagya (samikshan at gmail.com)

--- Additional comment from Worker Ant on 2016-12-01 08:12:08 EST ---

COMMIT: http://review.gluster.org/15975 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 331a45942333e27f596b1930f7d459f59850c8a4
Author: Samikshan Bairagya <samikshan at gmail.com>
Date:   Wed Nov 30 14:35:59 2016 +0530

    glusterd, cli: Fix volume options output format in get-state cli

    Currently the get-state cli outputs the volume options in the
    following format:

    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    [Volume1.options]
    features.barrier: on
    transport.address-family: inet
    performance.readdir-ahead: on
    nfs.disable: on

    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute

    This above format is a valid ini file format syntactically, but is
    not very easily parseable. This patch changes the format to look like
    the following and should be more easily parseable:

    Volume1.rebalance.skipped: 0
    Volume1.rebalance.lookedup: 0
    Volume1.rebalance.files: 0
    Volume1.rebalance.data: 0Bytes
    Volume1.options.features.barrier: on
    Volume1.options.transport.address-family: inet
    Volume1.options.performance.readdir-ahead: on
    Volume1.options.nfs.disable: on

    Volume2.name: tv2
    Volume2.id: 35854708-bb72-45a5-bdbd-77c51e5ebfb9
    Volume2.type: Distribute

    Change-Id: I9768b45de288d9817ec669d3a801874eb1914750
    BUG: 1399995
    Signed-off-by: Samikshan Bairagya <samikshan at gmail.com>
    Reviewed-on: http://review.gluster.org/15975
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Shubhendu Tripathi <shtripat at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1399995
[Bug 1399995] Dump volume specific options in get-state output in a more
parseable manner
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.