[Bugs] [Bug 1184358] New: glfs_set_volfile_server() should accept NULL as transport

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1184358

            Bug ID: 1184358
           Summary: glfs_set_volfile_server() should accept NULL as
                    transport
           Product: GlusterFS
           Version: 3.6.1
         Component: libgfapi
          Keywords: Patch, Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: ndevos at redhat.com
        QA Contact: sdharane at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1183547



+++ This bug was initially created as a clone of Bug #1183547 +++

Description of problem:
The documentation of glfs_set_volfile_server() mentions that transport may be
passed as a NULL value. However, this is not handled correctly and the function
will return EINVAL.

Version-Release number of selected component (if applicable):
Current mainline, and older versions.

How reproducible:
100%

Steps to Reproduce:
1. pass transport=NULL to glfs_set_volfile_server()

Actual results:
glfs_set_volfile_server() returns an error (EINVAL).

Expected results:
Default values for transport should be used, and connecting to the volume
should work.

--- Additional comment from Anand Avati on 2015-01-19 11:18:05 CET ---

REVIEW: http://review.gluster.org/9464 (gfapi: allow transport=NULL for
set_volfile_server()) posted (#1) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Anand Avati on 2015-01-20 21:39:59 CET ---

COMMIT: http://review.gluster.org/9464 committed in master by Shyamsundar
Ranganathan (srangana at redhat.com) 
------
commit cdb3fa6088957ed257bfe2c3af59a80033cb2cbb
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Jan 19 11:17:20 2015 +0100

    gfapi: allow transport=NULL for set_volfile_server()

    Users of gfapi should not need to care about the supported transport
    methods, this is an advanced option. Simple use-cases for libgfapi
    should be able to pass NULL as transport, and the libraries should take
    care of connecting to the Gluster server(s) correctly.

    BUG: 1183547
    Change-Id: Id93f96a3d10ae9fb69d53192642145ba8deed863
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9464
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1183547
[Bug 1183547] glfs_set_volfile_server() should accept NULL as transport
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.