[Bugs] [Bug 1175755] SNAPSHOT[USS]:gluster volume set for uss doesnot check any boundaries

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1175755

Raghavendra Bhat <rabhat at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rabhat at redhat.com



--- Comment #5 from Raghavendra Bhat <rabhat at redhat.com> ---
Description of problem:
gluster volume set <vol-name> features.uss doesnot check any boundary value.

How reproducible:
100%

Steps to Reproduce:
1.gluster volume set <vol-name> features.uss <invalid-value>
2.
3.

Actual results:
It doesnot give any error

Expected results:
If invalid value is passed the 'gluster volume set" command should through
acceptable values and command should fail.


Additional info:
[root at snapshot09 ~]# gluster volume info

Volume Name: newvol
Type: Distributed-Replicate
Volume ID: cadc8635-d42b-4715-8447-d4fed9537f6a
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick2/newvol
Brick2: hostname2:/brick2/newvol
Brick3: hostname3:/brick2/newvol
Brick4: hostname4:/brick2/newvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: enable
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256

Volume Name: testvol
Type: Distributed-Replicate
Volume ID: 723f20ad-99a2-4d85-8942-7cec20944676
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick1/testvol
Brick2: hostname2:/brick1/testvol
Brick3: hostname3:/brick1/testvol
Brick4: hostname4:/brick1/testvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: enable
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256
[root at snapshot09 ~]# gluster volume set features.uss sfdddsdds
Usage: volume set <VOLNAME> <KEY> <VALUE>
[root at snapshot09 ~]# gluster volume set testvol features.uss sfdddsdds
volume set: success
[root at snapshot09 ~]# gluster volume info

Volume Name: newvol
Type: Distributed-Replicate
Volume ID: cadc8635-d42b-4715-8447-d4fed9537f6a
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick2/newvol
Brick2: hostname2:/brick2/newvol
Brick3: hostname3:/brick2/newvol
Brick4: hostname4:/brick2/newvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: enable
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256

Volume Name: testvol
Type: Distributed-Replicate
Volume ID: 723f20ad-99a2-4d85-8942-7cec20944676
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick1/testvol
Brick2: hostname2:/brick1/testvol
Brick3: hostname3:/brick1/testvol
Brick4: hostname4:/brick1/testvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: sfdddsdds
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256
[root at snapshot09 ~]# gluster volume set testvol features.uss -1
volume set: success

[root at snapshot09 ~]# gluster volume info

Volume Name: newvol
Type: Distributed-Replicate
Volume ID: cadc8635-d42b-4715-8447-d4fed9537f6a
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick2/newvol
Brick2: hostname2:/brick2/newvol
Brick3: hostname3:/brick2/newvol
Brick4: hostname4:/brick2/newvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: enable
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256

Volume Name: testvol
Type: Distributed-Replicate
Volume ID: 723f20ad-99a2-4d85-8942-7cec20944676
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick1/testvol
Brick2: hostname2:/brick1/testvol
Brick3: hostname3:/brick1/testvol
Brick4: hostname4:/brick1/testvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: -1
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256
[root at snapshot09 ~]# gluster volume set testvol features.uss
@@@@@@@@@@@@@@@#$#$ns
volume set: success
[root at snapshot09 ~]# gluster volume info

Volume Name: newvol
Type: Distributed-Replicate
Volume ID: cadc8635-d42b-4715-8447-d4fed9537f6a
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick2/newvol
Brick2: hostname2:/brick2/newvol
Brick3: hostname3:/brick2/newvol
Brick4: hostname4:/brick2/newvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: enable
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256

Volume Name: testvol
Type: Distributed-Replicate
Volume ID: 723f20ad-99a2-4d85-8942-7cec20944676
Status: Started
Snap Volume: no
Number of Bricks: 2 x 2 = 4
Transport-type: tcp
Bricks:
Brick1: hostname1:/brick1/testvol
Brick2: hostname2:/brick1/testvol
Brick3: hostname3:/brick1/testvol
Brick4: hostname4:/brick1/testvol
Options Reconfigured:
performance.readdir-ahead: on
features.barrier: disable
features.uss: @@@@@@@@@@@@@@@#0
auto-delete: disable
snap-max-soft-limit: 90
snap-max-hard-limit: 256
[root at snapshot09 ~]# 

[root at snapshot09 ~]# gluster volume set testvol features.uss
@@@@@@@@@@@@@@@#$#$ns
volume set: success
[root at snapshot09 ~]# echo $?
0
[root at snapshot09 ~]#

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.