[Bugs] [Bug 1149943] duplicate librsync code should likely be linked removed and linked as a library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1149943

Niels de Vos <ndevos at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Comment #14 is|1                           |0
            private|                            |
              Flags|                            |needinfo?(wmealing at redhat.c
                   |                            |om)



--- Comment #15 from Niels de Vos <ndevos at redhat.com> ---
Wade, Pranith has a point there, the function is explicitly called
gf_rsync_weak_checksum(). Replacing the implementation with a strong checksum
does not really make much sense...

(Changing the algorithm would possibly introduce continuous healing of data
that is already correct, in the case where users have different versions
installed - performance impact.)

The performance difference between weak/strong checksums may not be very
relevant anymore? If that is the case, we could maybe remove
gf_rsync_weak_checksum() completely and use the MD5 checksumming from
gf_rsync_strong_checksum() for everything. Adding a function to do sha256 just
to replace adler32 does look like a good approach to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HXAljfZUbS&a=cc_unsubscribe