[Bugs] [Bug 1178134] New: Dentries with trailing '/' are added when quota is enabled in bricks

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1178134

            Bug ID: 1178134
           Summary: Dentries with trailing '/' are added when quota is
                    enabled in bricks
           Product: Red Hat Storage
           Version: 3.0
         Component: glusterfs
     Sub Component: core
          Assignee: vbellur at redhat.com
          Reporter: pkarampu at redhat.com
        QA Contact: sdharane at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1158751
            Blocks: 1163570
             Group: redhat



+++ This bug was initially created as a clone of Bug #1158751 +++

Description of problem:
    inode_link is sometimes called with a trailing '/'. Lookup, dentry
    operations like link/unlink/mkdir/rmdir/rename etc come without trailing
    '/' so the stale dentry with '/' remains in the dentry list of the inode.


Version-Release number of selected component (if applicable):


How reproducible:
always with quota

Steps to Reproduce:
1. create plain replicate volume 'r2'
2. create a directory hierarcy a/b/c
3. open fd exec 5>a/b/c/f.txt
4. kill 1st brick and restart it
5. write something to fd i.e. echo abc >&5
6. This populates dentries with names with trailing '/'

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-10-30 02:14:24 EDT ---

REVIEW: http://review.gluster.org/9004 (inode: Canonicalize filename for dentry
creation) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-03 10:48:30 EST ---

REVIEW: http://review.gluster.org/9004 (inode: Handle '/' in basename in
inode_link/unlink) posted (#2) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-06 01:18:16 EST ---

REVIEW: http://review.gluster.org/9004 (inode: Handle '/' in basename in
inode_link/unlink) posted (#3) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-07 12:42:33 EST ---

COMMIT: http://review.gluster.org/9004 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 0d7fd69b01cf9aebb4f1517f064e89ff65b9ccf8
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Thu Oct 30 10:56:17 2014 +0530

    inode: Handle '/' in basename in inode_link/unlink

    Problem:
    inode_link is sometimes called with a trailing '/'. Lookup, dentry
    operations like link/unlink/mkdir/rmdir/rename etc come without trailing
    '/' so the stale dentry with '/' remains in the dentry list of the inode.

    Fix:
    Add assert checks and return NULL for '/' in bname.
    Fix ancestry building code to call without '/' at the end.

    Change-Id: I9c71292a3ac27754538a4e75e53290e182968fad
    BUG: 1158751
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/9004
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1158751
[Bug 1158751] Dentries with trailing '/' are added when quota is enabled in
bricks
https://bugzilla.redhat.com/show_bug.cgi?id=1163570
[Bug 1163570] Dentries with trailing '/' are added when quota is enabled in
bricks
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VsJFfMMapT&a=cc_unsubscribe