[Bugs] [Bug 1145086] New: [SNAPSHOT]: Snapshot of volume with thick provisioned LV as bricks does not give proper error message

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1145086

            Bug ID: 1145086
           Summary: [SNAPSHOT]: Snapshot of volume with thick provisioned
                    LV as bricks does not give proper error message
           Product: GlusterFS
           Version: 3.6.0
         Component: core
          Severity: high
          Priority: urgent
          Assignee: gluster-bugs at redhat.com
          Reporter: spandit at redhat.com
                CC: asengupt at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, rhinduja at redhat.com,
                    rjoseph at redhat.com
        Depends On: 1123646



+++ This bug was initially created as a clone of Bug #1123646 +++

Description of problem:

Snapshot is supported only for thinly provisioned LV. Therefore to take
snapshot all the bricks of the volume must be on thinly provisioned LV, 

Snapshot command does fail if one or more brick(s) are thick LV, but the error
message is not clear. It fails with the following error message:

"snapshot create: failed: Commit failed on localhost. Please check log file for
details."


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
Snapshot command fail if one or more brick(s) are thick LV, but the error
message is not clear. It fails with the following error message:

"snapshot create: failed: Commit failed on localhost. Please check log file for
details."


Expected results:
Snapshot command should fail with accurate error message.

Additional info:

--- Additional comment from Anand Avati on 2014-07-27 10:45:48 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for
snapshot create command) posted (#1) for review on master by Rajesh Joseph
(rjoseph at redhat.com)

--- Additional comment from Anand Avati on 2014-07-28 02:33:06 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for
snapshot create command) posted (#2) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2014-07-30 02:17:28 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for
snapshot create command) posted (#3) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2014-07-30 05:34:53 EDT ---

REVIEW: http://review.gluster.org/8377 (glusterd/snapshot: Proper err msg for
snapshot create command) posted (#4) for review on master by Krishnan
Parthasarathi (kparthas at redhat.com)

--- Additional comment from Anand Avati on 2014-07-30 05:35:08 EDT ---

COMMIT: http://review.gluster.org/8377 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 8732ee5319bfe4649473c29458a6ab65b73d5516
Author: Rajesh Joseph <rjoseph at redhat.com>
Date:   Sun Jul 27 10:36:52 2014 -0400

    glusterd/snapshot: Proper err msg for snapshot create command

    problem: Snapshot command fails if one or more bricks are not thinly
    provisioned. But the error message is a generic error message which
    is confusing to the user.

    fix: Provide correct error message in case of failure.

    Change-Id: Iad247f966423a8f73ef6da57cab7ed6cddc05861
    BUG: 1123646
    Signed-off-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-on: http://review.gluster.org/8377
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1123646
[Bug 1123646] [SNAPSHOT]: Snapshot of volume with thick provisioned LV as
bricks does not give proper error message
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HuORoAYKWn&a=cc_unsubscribe