[Bugs] [Bug 1140847] ec tests fail on NetBSD

bugzilla at redhat.com bugzilla at redhat.com
Fri Sep 19 19:31:55 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1140847



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/8780 committed in release-3.6 by Vijay Bellur
(vbellur at redhat.com) 
------
commit b8c820be5f1d3ad7f60a2a0c7256081491d79d51
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Wed Sep 10 23:43:07 2014 +0200

    ec: Fix invalid inode lock in ftruncate

    The fops 'truncate' and 'ftruncate' share some code and inodelk()
    was always made against the inode inside the loc_t structure
    instead of that of fd_t. Since ftruncate has the loc initialized
    to NULL, this fop was executed without any lock, allowing some
    concurrent modifications in the file size.

    Also changed the way in which 'fop' and 'ffop' are differentiated
    in shared code. Now it uses 'id' field instead of checking if 'fd'
    is NULL.

    This is a backport of http://review.gluster.org/8695/

    Change-Id: Ibd18accf2652193b395a841b9029729e5f4867c6
    BUG: 1140847
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/8780
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OeL6FEXaFa&a=cc_unsubscribe


More information about the Bugs mailing list