[Gluster-Maintainers] Handling github PRs
Niels de Vos
ndevos at redhat.com
Wed Mar 1 22:22:06 UTC 2017
On Wed, Mar 01, 2017 at 02:43:44PM -0500, Shyam wrote:
> We do not accept github PRs as our work flow is gerrit based.
> To educate contributors, one of the things we could do is to put up a
> template as in  for the PULL_REQUEST_TEMPLATE. It will look like this 
> when users attempt to submit PRs.
> An alternate idea suggested by Nigel was to accept PRs, but use a Jenkins
> job to auto close the same, with some generic (or very specific)
> instructions on how to submit it to our gerrit instance.
> The advantage of the latter method is that we do not lose the code change
> suggested, and we can still evaluate the same and reach out to the
> contributor and also possibly get the change into our gerrit instance.
> The latter approach looks good, wanted to run this by other maintainers for
> their thoughts.
How many PR's do we get? If it is 'a lot', then the time to invest in
the 2nd approach would be ok, otherwise a simple template is probably
sufficient (and Nigel can spend his time on more urgent tasks).
>  PR template:
>  How a PR template appears to contributors:
> maintainers mailing list
> maintainers at gluster.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 801 bytes
Desc: not available
More information about the maintainers