[GEDI] [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

Markus Armbruster armbru at redhat.com
Thu Jan 28 07:45:51 UTC 2021


Eric Blake <eblake at redhat.com> writes:

> On 1/26/21 3:31 AM, Markus Armbruster wrote:
>> Eric Blake <eblake at redhat.com> writes:
>> 
>>> These cases require a bit more thought to review; in each case, the
>>> code was appending to a list, but not with a FOOList **tail variable.
>>>
>>> Signed-off-by: Eric Blake <eblake at redhat.com>
>>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov at virtuozzo.com>
>>>
>>> ---
>>> fix qmp_guest_network_get_interfaces [Vladimir]
>> 
>> Fails tests/test-qga.  I should've double-checked earlier.
>
> I ran 'make check', but I'll check again.  In the meantime,
>
>
>> 
>> Dropping this part unbreaks the test.
>> 
>> I'd like to drop just this part, and merge the rest.  You can then
>> respin just this part as a follow-up patch.  Okay?
>
> this plan is okay with me.

Done.  Thanks!



More information about the integration mailing list